[submodule] Advance sonic-py-swsssdk pointer#12559
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Nov 14, 2022
Merged
[submodule] Advance sonic-py-swsssdk pointer#12559liat-grozovik merged 2 commits intosonic-net:masterfrom
liat-grozovik merged 2 commits intosonic-net:masterfrom
Conversation
Update sonic-py-swsssdk submodule pointer to include the following: * e30a1e1 Throw exception when not use swsssdk in UT. ([sonic-net#126](sonic-net/sonic-py-swsssdk#126)) Signed-off-by: dprital <[email protected]>
Collaborator
|
@liuh-80 Could you help check the build failure? Related to swsssdk deprecation. |
Contributor
|
The change in swsssdk been tested with this PR: https://github.com/sonic-net/sonic-buildimage/pull/12036/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584 The issue happen because currently sonic-build-image using python2 to build image, I will check if it's a build pipeline issue. |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@dprital , the UT failed with python2 issue fixed with this PR: sonic-net/sonic-py-swsssdk#128 |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Nov 14, 2022
davidpil2002
pushed a commit
to davidpil2002/sonic-buildimage
that referenced
this pull request
Nov 15, 2022
Update sonic-py-swsssdk submodule pointer to include the following: 7f008a1 Fix UT test_BlockUseSwsssdk() (sonic-net#128) e30a1e1 Throw exception when not use swsssdk in UT. (sonic-net#126) Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dprital [email protected]
Why I did it
Update sonic-py-swsssdk submodule pointer to include the following:
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)