Skip to content

Bug:[Smartswitch] Issues caused due to introduction of the chassisd/sonic-utiltiies changes for consecutive admin state changes #23205

@gpunathilell

Description

@gpunathilell

Is it platform specific

generic

Importance or Severity

Critical

Description of the bug

There are 3 issues introduced as part of introduciton of the following PRs:
sonic-net/sonic-platform-daemons#607
sonic-net/sonic-utilities#3937

Traceback during show chassis modules status command:


show chassis modules status                                                                                                                                                                        
 File "/usr/local/lib/python3.11/dist-packages/show/chassis_modules.py", line 61, in status
   desc = data_dict[CHASSIS_MODULE_INFO_DESC_FIELD]
         ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'desc'

chassisd crash:

2025 Jul  3 14:19:59.997881 sonic INFO pmon#supervisord: chassisd   File "/usr/local/bin/chassisd", line 1460, in run
2025 Jul  3 14:19:59.998137 sonic INFO pmon#supervisord: chassisd     self.module_updater.module_db_update()
2025 Jul  3 14:19:59.998235 sonic INFO pmon#supervisord: chassisd   File "/usr/local/bin/chassisd", line 804, in module_db_update
2025 Jul  3 14:19:59.998408 sonic INFO pmon#supervisord: chassisd     prev_status = self.get_module_current_status(key)
2025 Jul  3 14:19:59.998523 sonic INFO pmon#supervisord: chassisd                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025 Jul  3 14:19:59.998523 sonic INFO pmon#supervisord: chassisd   File "/usr/local/bin/chassisd", line 362, in get_module_current_status
2025 Jul  3 14:19:59.998624 sonic INFO pmon#supervisord: chassisd     return fvs[CHASSIS_MODULE_INFO_OPERSTATUS_FIELD]
2025 Jul  3 14:19:59.998736 sonic INFO pmon#supervisord: chassisd            ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025 Jul  3 14:19:59.998736 sonic INFO pmon#supervisord: chassisd KeyError: 'oper_status'

Removal of pre-shutdown call during initialization:
The Dpu initialization pre_shutdown call was removed as part of the sonic-platform-daemons PR introduction
Image

The first two issues are because of the transition field introduction in CHASSIS_MODULE_TABLE the expectation from sonic-utilities and chassisd is that when the table is avaiable the oper_status and description fields are already populated. this needs to be pudated as the CHASSIS_MODULE_TABLE can be created on initialization or execution of the shutdown/startup commands without oper_status or description.

Steps to Reproduce

install latest master image on smartswitch and execute:
show chassis modules status on switch
and observer syslog

Actual Behavior and Expected Behavior

Actual behaviour:
crash on chassisd and traceback seen on command execution
No tracebacks on command execution and no chassisd crashes

Relevant log output

Output of show version, show techsupport

master

Attach files (if any)

No response

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions