[pytest]: Ignore errors deleting host ifs (#2005)

theasianpianist · web-flow · commit fe5b2a99d955 · 2021-11-08T13:18:12.000-08:00
The delete command for host interfaces during virtual server set up can occasionally fail if the interface has been auto-deleted before the command is run. This causes cascading failures for the VS test suite. Ignore such an error if this occurs.

Signed-off-by: Lawrence Lee &lt;lawlee@microsoft.com&gt;
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -187,7 +187,15 @@ def __init__(self, ctn_name: str, pid: int, i: int):
             # ensure self.pifname is not already an interface in the DVS net namespace
             rc, _ = subprocess.getstatusoutput(f"nsenter -t {pid} -n ip link show | grep '{self.pifname}@'")
             if not rc:
-                ensure_system(f"nsenter -t {pid} -n ip link delete {self.pifname}")
+                try:
+                    ensure_system(f"nsenter -t {pid} -n ip link delete {self.pifname}")
+                except RuntimeError as e:
+                    # Occasionally self.pifname will get deleted between us checking for its existence
+                    # and us deleting it ourselves. In this case we can continue normally
+                    if "cannot find device" in str(e).lower():
+                        pass
+                    else:
+                        raise e
 
             ensure_system(f"ip netns exec {self.nsname} ip link set {self.pifname} netns {pid}")
 
