Ignore failures in enabling a systemd service (#320)

saiarcot895 · web-flow · commit ce60800180bf · 2025-11-21T14:39:42.000-08:00
With Trixie, there will be services that will be defined in /run/systemd/generator (this is a workaround for dealing with restrictions from systemd placed on service generators and for multi-ASIC units). Enabling such services fails because it's assumed to be always enabled.

Therefore, if the enable command for some service fails, don't treat it as a hard error, and continue.

Additionally, change the featured.timer to restart featured every 1 second instead of instantaneously. This prevents a CPU and syslog flood from happening on initial bringup of certain topologies (multi ASIC and T2) on KVM; physical devices are likely unaffected.
diff --git a/data/debian/sonic-host-services-data.featured.timer b/data/debian/sonic-host-services-data.featured.timer
@@ -3,7 +3,7 @@ Description=Delays feature daemon until SONiC has started
 PartOf=featured.service
 
 [Timer]
-OnUnitActiveSec=0 sec
+OnUnitActiveSec=1 sec
 OnBootSec=1min 30 sec
 Unit=featured.service
 
diff --git a/scripts/featured b/scripts/featured
@@ -437,7 +437,21 @@ class FeatureHandler(object):
             for cmd in cmds:
                 syslog.syslog(syslog.LOG_INFO, "Running cmd: '{}'".format(cmd))
                 try:
-                    run_cmd(cmd, raise_exception=True)
+                    if "enable" in cmd:
+                        # If we are running an enable command, then ignore any errors that might come
+                        # from the service file being defined only in the /run folder. This is because
+                        # it doesn't make sense to enable generated services. In Trixie, because of
+                        # restrictions from systemd and limitations around resetting fields relating
+                        # to dependencies, we are basically copying the service files from the /usr/lib
+                        # folder to /run, except for any dependency-related fields.
+                        #
+                        # We need a better solution to this, maybe something like custom fields in
+                        # the service files for specifying SONiC dependencies. That way, our service
+                        # generator can just look for that and translate that to either non-instanced
+                        # units or to instanced units and add those as dependencies.
+                        run_cmd(cmd, raise_exception=False)
+                    else:
+                        run_cmd(cmd, raise_exception=True)
                 except Exception as err:
                     syslog.syslog(syslog.LOG_ERR, "Feature '{}.{}' failed to be enabled and started"
                                   .format(feature.name, feature_suffixes[-1]))
