Meet Marketplace requirements #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
To figure out: What's the impact for upgrading for existing users of sonar-perl? To my understanding you will need to uninstall the current plugin and you will lose project annalysis history. |
milbrandt
reviewed
Jun 30, 2019
milbrandt
left a comment
milbrandt
left a comment
There was a problem hiding this comment.
Where I'm in doubt is the key in the constructor of com.github.sonarperl.PerlLanguage. Is it there admissible to use just the language name as this indicates the repository of rules. Or do we need to oberserve rule 3e here also? That should be clarified with Sonarqube.
Changing the key will also break the configuration of all existing user-defined Quality Profiles as they are liked to the plugin key.
...-perl-plugin/src/test/java/com/github/sonarperl/critic/PerlCriticIssuesLoaderSensorTest.java
Show resolved
Hide resolved
otrosien
force-pushed
the
marketplace-prep
branch
from
b021aaf to
db6871f
Compare
3. The key of your plugin must be: e. not just the name of a language (e.g. cannot be java, rust, js/javascript, ...) https://docs.sonarqube.org/display/DEV/Deploying+to+the+Marketplace Remove some code smell Remove potential security vulnerability Add assertion to test case Add assertion to test case Use communityperl as plugin key
otrosien
force-pushed
the
marketplace-prep
branch
from
db6871f to
79384e3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e. not just the name of a language (e.g. cannot be java, rust, js/javascript, ...)
https://community.sonarsource.com/t/deploying-to-the-marketplace/35236
Closes #133