Skip to content

fix: last release due to workspace alias and changeset - #135

Merged
belgattitude merged 2 commits into
mainfrom
fix-releases
Oct 11, 2021
Merged

fix: last release due to workspace alias and changeset#135
belgattitude merged 2 commits into
mainfrom
fix-releases

Conversation

@belgattitude

@belgattitude belgattitude commented Oct 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Changeset does not handle yarn v3+ workspace aliases right now. See issue changesets/changesets#432 and P/R at changesets/changesets#585.

  1. We can use yarn pack that will create a correct release (workspace:* versions will be replaced)
  2. untar the generated package.tgz into a _release folder
  3. set publishConfig.directory to point this folder
  4. call changeset publish

Basically:

 "publishConfig": {
    "directory": "_release/package"
  },
  "scripts": {
    "?build-publishable-release": "Workaround for changeset and workspace protocol: https://github.com/atlassian/changesets/pull/585",
    "build-publishable-release": "yarn build && rimraf ./_release && yarn pack && mkdir ./_release && tar zxvf ./package.tgz --directory ./_release && rm ./package.tgz",
}

@changeset-bot

changeset-bot Bot commented Oct 11, 2021 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d65f549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@soluble/cache-ioredis Patch
@soluble/cache-redis Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qlty-cloud-legacy

qlty-cloud-legacy Bot commented Oct 11, 2021 •
edited
Loading

Copy link
Copy Markdown

Code Climate has analyzed commit d65f549 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov

codecov Bot commented Oct 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #135 (d65f549) into main (b959ac7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          36       36           
  Lines         644      644           
  Branches      176      176           
=======================================
  Hits          603      603           
  Misses         41       41
Flag Coverage Δ
cache_interop_unit 59.74% <ø> (ø)
cache_ioredis_unit 49.20% <ø> (ø)
cache_redis_unit 45.23% <ø> (ø)
dsn_parser_unit 100.00% <ø> (ø)
e2e 85.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@belgattitude
belgattitude merged commit e54184c into main Oct 11, 2021
@github-actions github-actions Bot mentioned this pull request Oct 11, 2021
Merged
@belgattitude belgattitude mentioned this pull request Oct 12, 2021
Closed
@belgattitude
belgattitude deleted the fix-releases branch October 13, 2021 20:05
@belgattitude belgattitude mentioned this pull request Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@belgattitude