Skip to content

Commit 8151540

Browse files
authored
Denylists b-series powervr from vulkan (flutter#191808)
The b-series of powervr seemed okay with quick testing. It was enabled in flutter#173561 but since then we've gotten quite a few reports against it. Let's disable it from vulkan again. fixes flutter#181315 fixes flutter#191457 fixes flutter#191351 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent e95fb62 commit 8151540

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ bool DriverInfoVK::IsKnownBadDriver() const {
422422
// https://github.com/flutter/flutter/issues/160866
423423
// https://github.com/flutter/flutter/issues/160804
424424
// https://github.com/flutter/flutter/issues/160406
425-
if (powervr_gpu_.has_value() && powervr_gpu_.value() < PowerVRGPU::kBXE) {
425+
if (powervr_gpu_.has_value() && powervr_gpu_.value() < PowerVRGPU::kCXT) {
426426
return true;
427427
}
428428
return false;

‎engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ TEST(DriverInfoVKTest, PowerVRBSeries) {
299299
})
300300
.Build();
301301

302-
EXPECT_FALSE(context->GetDriverInfo()->IsKnownBadDriver());
302+
EXPECT_TRUE(context->GetDriverInfo()->IsKnownBadDriver());
303303
EXPECT_EQ(context->GetDriverInfo()->GetPowerVRGPUInfo(),
304304
std::optional<PowerVRGPU>(PowerVRGPU::kBXM));
305305
}

0 commit comments

Comments
 (0)