Skip to content

Fix vite6 environment detection #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birkskyum merged 2 commits into from
Jan 31, 2025
Merged

Fix vite6 environment detection #173

birkskyum merged 2 commits into from
Jan 31, 2025

Conversation

@brenelz
Copy link
Contributor

@brenelz brenelz commented Jan 31, 2025 •
edited by birkskyum
Loading

I believe this fixes the "Client-only API called on the server side. Run client-only code in onMount, or conditionally run" error when using vite6.

I'm not 100% on the implementation but tried to replicate the conditions that were removed in this pr. I am not sure if there is an order to where it picks up. I think development and browser weren't being added correctly and they were before.

https://github.com/solidjs/vite-plugin-solid/pull/163/files

Closes #171

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2a72396

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-plugin-solid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

birkskyum
birkskyum approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@birkskyum birkskyum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running with vitest, this fixes a ton of issues.

Before, I got hundreds of this generic:
Error: Client-only API called on the server side. Run client-only code in onMount, or conditionally run client-only component with .

After, I get actual useful messages:
Warning: useRouter must be used inside a component!

@birkskyum
Copy link
Member

birkskyum commented Jan 31, 2025

@brenelz , can you add a patch changeset to this?

@birkskyum birkskyum mentioned this pull request Jan 31, 2025
Merged
@birkskyum
Copy link
Member

birkskyum commented Jan 31, 2025 •
edited
Loading

There is confirmation that this fixes also:

Confirmed by this stackblitz

https://stackblitz.com/edit/vitejs-vite-1k7n1gjp?file=src%2FApp.jsx

@birkskyum birkskyum mentioned this pull request Jan 31, 2025
Closed
@birkskyum birkskyum closed this Jan 31, 2025
@birkskyum birkskyum reopened this Jan 31, 2025
@birkskyum
Copy link
Member

birkskyum commented Jan 31, 2025 •
edited
Loading

We think the new CR flow break because the workflow was added after this PR was opened.

EDIT: it was github app permissions - works now.

@birkskyum birkskyum merged commit c5ddd03 into solidjs:main Jan 31, 2025
2 of 3 checks passed
@birkskyum birkskyum mentioned this pull request Feb 2, 2025
Closed
@incognitojam incognitojam mentioned this pull request Feb 6, 2025
Merged
@benoitv-code benoitv-code mentioned this pull request Apr 24, 2025
Closed
@benoitv-code benoitv-code mentioned this pull request Jun 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birkskyum birkskyum birkskyum approved these changes

@atilafassina atilafassina Awaiting requested review from atilafassina

@ryansolid ryansolid Awaiting requested review from ryansolid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting resolve.conditions causes Vite dev server run into infinite loop

3 participants

@brenelz @birkskyum @ryansolid