fix: prevent duplicating config.test entries#101
Merged
ryansolid merged 1 commit intosolidjs:masterfrom Oct 10, 2023
Merged
Conversation
|
Oh my gosh I think I finally found my problem!! This has been driving me nuts for a while now but all my unit tests are running twice when I have the vite solid plugin enabled. @AriPerkkio is this likely the same issue? Details: when using vitest, whenever I have the vite solid plugin enabled, all my unit tests (whether the tests use solidjs or not) run twice! It is super odd and frustrating that I cannot get to the bottom of it. See here: #112 (comment) cc @ryansolid is there any way we can get this PR merged? 🙏 Thanks! |
This was referenced Sep 12, 2023
|
Thank you! |
|
This PR definitely caused bug #120 |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text-summaryortextcoverage report vitest-dev/vitest#3439Do not duplicate
config.testentries onconfigplugin hook. Vite will merge these and the user provided configurations are duplicated.Minimal reproduction:
Without fix, see how
config.testis duplicated. Also note howconfig.esbuildis automatically merged even when this plugin does not merge those manually:With fix: