Skip to content

Commit a289242

Browse files
committed
fix: move delete stream.then after dev-server branch to restore thenable
1 parent 47d5e6a commit a289242

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎packages/start/src/server/handler.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,15 @@ export function createBaseHandler(
114114

115115
if (mode === "async") return await stream;
116116

117-
delete (stream as any).then;
118-
119117
// using TransformStream in dev can cause solid-start-dev-server to crash
120118
// when stream is cancelled
121119
if (globalThis.USING_SOLID_START_DEV_SERVER) return stream;
122120

121+
// remove thenable so h3/Cloudflare Workers do not await the stream object;
122+
// must happen after the dev-server branch so the stream remains awaitable
123+
// when returned to solid-start-dev-server above
124+
delete (stream as any).then;
125+
123126
// returning stream directly breaks cloudflare workers
124127
const { writable, readable } = new TransformStream();
125128
stream.pipeTo(writable);

0 commit comments

Comments
 (0)