Skip to content

refactor(signals): remove the dead latest-opened hold arm - #4754

Merged
ryansolid merged 2 commits into
nextfrom
tembo/dead-latest-opened
Nov 10, 2026
Merged

refactor(signals): remove the dead latest-opened hold arm#4754
ryansolid merged 2 commits into
nextfrom
tembo/dead-latest-opened

Conversation

@ryansolid

@ryansolid ryansolid commented Nov 10, 2026

Copy link
Copy Markdown
Member

What

Removes latestOpened / openedByLatest (scheduler.ts), the stagedScreen arm that tested flushTransaction === latestOpened (core.ts), and the seat table's copy of that test (seat.ts, __TEST__ only). The mechanism carried D-22's "a transaction only a latest() read opened" case; latest() has opened no transaction since #4393 (81a12d8), which deleted the only call of openedByLatest, so the flag has been null ever since and the arm could never run inside a flush.

Found by the unreached-arm inventory (reader-seat-rebuild.md §9.5 on tembo/size-seat-measure): V8 statement coverage merged across the signals suite, web default / hydrate / server, solid, and the async generator at 50,000 cases × seeds 3289 / 7 / 91501, all resolving @solidjs/signals to the same source lines. This is the one Tier-1 arm that is dead by construction rather than merely unreached; the other three (bornHeldOpen + attachWaits' tail, heldBy's true path, under + linkLanes' group merge) are listed there for a ruling.

No rule or comment in the docs describes the removed case; the two source comments that did are rewritten.

Gates

  • signals 6,758 passed; seat shadow: the same 7 classes as next.
  • web rulings 110 passed; web default 1,831 passed.
  • node scripts/rules-index.mjs --check clean; RULES-INDEX.md regenerated.
  • A statement no run executes cannot move a screen, so no new 50k recording was needed; the inventory's 150k cases are the differential.

Size (local, base next @ 78eaf88)

scenario delta br / min
signals: core floor 0 / 0
signals: + isPending/latest −21 / −63
signals: + until/refresh 0 / 0

No cap changes (every scenario stays under its cap).


Want tembo to make any changes? Add a comment with @tembo and i'll get back to work!

View on Tembo  Review in Tembo  View Agent Settings

@ryansolid @tembo
refactor(signals): remove the dead latest-opened hold arm (#4393 left…
f074e1a 
… no caller)

Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com>
@tembo tembo Bot added tembo Pull request created by Tembo labels Nov 10, 2026
@changeset-bot

changeset-bot Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 41bbb7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@solidjs/signals Patch
test-integration Patch
@solidjs/web Patch
@solidjs/babel-plugin Patch
@solidjs/compiler Patch
@solidjs/diagnostics Patch
@solidjs/element Patch
@solidjs/h Patch
@solidjs/html Patch
solid-js Patch
@solidjs/universal Patch
board-example Patch
canvas-example Patch
server-dbmon-example Patch
todos-server-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid @tembo
chore: drop the scratch coverage configs committed by mistake
41bbb7c 
Co-authored-by: tembo[bot] <208362400+tembo-io[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 10, 2026

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.42 KB 0 B 0 B −117 B 7.43 KB ✅
signals: + createStore 15.01 KB 0 B 0 B −202 B 15.13 KB ✅
signals: + isPending/latest 12.23 KB −23 B (−0.2%) −63 B −49 B 12.27 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.09 KB 0 B 0 B −44 B 8.12 KB ✅
app: render + one signal (the simple-app floor) 9.81 KB 0 B 0 B −130 B 9.81 KB ⚠️ over by 2 B, 150 B minified headroom
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 19.10 KB 0 B 0 B 0 B 19.11 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 34.35 KB 0 B 0 B +14 B 34.36 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.75 KB 0 B 0 B 0 B 13.77 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.48 KB 0 B 0 B +49 B 15.50 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 30.12 KB 0 B 0 B +75 B 30.16 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.99 KB 0 B 0 B −182 B 9.99 KB ⚠️ over by 1 B, 202 B minified headroom
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.57 KB 0 B 0 B −426 B 26.75 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.75 KB 0 B 0 B −421 B 33.00 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.77 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 34.07 KB 0 B 0 B +90 B 34.11 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.20 KB, wire.js 3.48 KB
page: live server components (base + live/GET + action + isPending/latest) 40.40 KB 0 B −64 B −50 B 40.43 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.19 KB, wire.js 3.48 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.89 KB 0 B 0 B −196 B 36.06 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.17 KB, wire.js 3.48 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 44.36 KB −26 B (−0.1%) −64 B −55 B 44.39 KB ✅ eager (counted): web.js 23.63 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.08 KB, sc-comments.js 0.19 KB, trace.js 9.20 KB, wire.js 3.48 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.55 KB 0 B 0 B +3 B 41.60 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.16 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 50.19 KB −8 B (−0.0%) −67 B −59 B 50.20 KB ✅ eager (counted): client.js 28.93 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.31 KB, trace.js 9.15 KB, wire.js 3.50 KB
server: floor (getRequestEvent + isServer) 1.27 KB 0 B 0 B 0 B 1.29 KB ✅
server: renderToString (the server-render floor) 22.93 KB 0 B 0 B +2 B 22.92 KB ⚠️ over by 9 B, 18 B minified headroom

⚠️ Over the brotli cap within the minified allowance (passes)

  • app: render + one signal (the simple-app floor): over brotli cap by 2 B; minified 26,624 B vs 26,754 B recorded with the cap (−130 B) — 150 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • app: compiled floor (one template, one text hole, one delegated click): over brotli cap by 1 B; minified 27,102 B vs 27,284 B recorded with the cap (−182 B) — 202 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • server: renderToString (the server-render floor): over brotli cap by 9 B; minified 77,890 B vs 77,888 B recorded with the cap (+2 B) — 18 B of the 20 B minified allowance left; +0 B minified over this PR's base

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

coveralls commented Nov 10, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 42894431943

Coverage remained the same at 78.945%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 1372
Covered Lines: 1143
Line Coverage: 83.31%
Relevant Branches: 1112
Covered Branches: 818
Branch Coverage: 73.56%
Branches in Coverage %: Yes
Coverage Strength: 30.12 hits per line
💛 - Coveralls

@codspeed

codspeed Bot commented Nov 10, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 6.99%

1 warning

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 1 improved benchmark
✅ 200 untouched benchmarks
⏩ 5 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ arrow in template 11.7 ms 10.9 ms +6.99%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

Comparing tembo/dead-latest-opened (41bbb7c) with next (8506dbf)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ryansolid
ryansolid merged commit d476295 into next Nov 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tembo Pull request created by Tembo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryansolid @coveralls