Repository navigation
fix(store): preserve class accessor precedence in createMutable - #4703
Merged
Merged
Conversation
Retain the nearest descriptor while walking class prototypes so ancestor accessors cannot replace derived or own properties.
Check derived accessors, instance accessors and own data properties, including reactive reads and derived setters.
Record the store bug fix as a patch release.
🦋 Changeset detectedLatest commit: 595ae87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createMutablecollects class descriptors from derived prototypes toward ancestors. Overwriting previously collected descriptors can replace an overridden or own property with an ancestor accessor.Preserve the first descriptor for each property while retaining key collection and proxy binding. Add regressions for derived getters/setters, instance accessors and instance data properties, plus a patch changeset.
How did you test this change?
pnpm run build— all 4 workspace tasks passed.pnpm run test— all 7 tasks passed, including 495 client tests, 18 server tests and the TypeScript tests.pnpm run coverage— all 495 client tests passed.pnpm exec prettier --check packages/solid/store/src/mutable.ts packages/solid/store/test/mutable.spec.ts .changeset/retain-mutable-class-descriptors.md— passed.The three new regressions failed against unmodified
bc50fe5and passed with this fix.