Skip to content

chore(size): re-record the ledger after #4611 - #4616

Merged
ryansolid merged 1 commit into
nextfrom
claude/size-ledger-after-4611
Nov 2, 2026
Merged

ryansolid merged 1 commit into
nextfrom
claude/size-ledger-after-4611

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Size-Exception: re-record after #4611, whose growth the maintainer accepted. Three frozen floors are re-recorded:

  • "app: hydrating" goes from 18.84 to 18.93 KB.
  • "page: base server components" goes from 33.83 to 33.91 KB.
  • "page: live server components" goes from 39.31 to 39.32 KB.

All three carry #4611's +145 to +150 B minified.

Before: next @ 97e1826 fails the size gate on the Loading rows with #4611's accepted growth, which also turns the size check red on every open PR.

After: every row CI measured above its recorded minified, or over its cap, is re-recorded.

The numbers come from next's own push size job, 125171473550 at 97e1826. Caps are measured brotli + 10 B, rounded up to 0.01 KB, and never lowered. Recorded minified equals the measured value.

Row Cap Recorded minified
app: hydrating (frozen floor) 18.84 → 18.93 KB 53,487 → 53,632
app: hydrating + every store 32.81 → 32.90 KB 99,010 → 99,155
app: CSR with Show/For/Loading/Errored/lazy 13.56 → 13.57 KB 36,956 → 37,100
app: CSR, observe tier 15.26 → 15.33 KB 41,911 → 42,055
app: CSR, observe tier + attribution engine 29.88 → 29.93 KB 88,348 → 88,386
app: compiled CSR 26.36 → 26.41 KB 80,127 → 80,107
app: compiled hydrating 32.61 → 32.66 KB 100,851 → 100,825
page: base server components (frozen floor) 33.83 → 33.91 KB 101,612 → 101,762
page: live server components (frozen floor) 39.31 → 39.32 KB 118,287 → 118,432
page: compiled base server components 35.82 → 35.84 KB 107,946 → 108,091
page: compiled live server components 43.26 → 43.30 KB 126,477 → 126,622
page: base + router 41.33 → 41.36 KB 125,625 → 125,770
page: live + router 48.97 → 49.00 KB 143,961 → 144,106

Hello world (app: compiled floor) is 9,974 B and keeps its 9.98 KB cap.


Generated by Claude Code

Re-record from next's push size job 125171473550 at 97e1826.
Caps are measured brotli + 10 B, never lowered; the hello-world
cap stays at 9.98 KB.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE
@changeset-bot

changeset-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d0acd11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.42 KB 0 B 0 B −91 B 7.43 KB ✅
signals: + createStore 15.00 KB 0 B 0 B 0 B 15.01 KB ✅
signals: + isPending/latest 11.45 KB 0 B 0 B 0 B 11.47 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.05 KB 0 B 0 B −84 B 8.06 KB ✅
app: render + one signal (the simple-app floor) 9.80 KB 0 B 0 B −150 B 9.80 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 18.91 KB 0 B 0 B 0 B 18.93 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 32.88 KB 0 B 0 B 0 B 32.90 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.55 KB 0 B 0 B 0 B 13.57 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.32 KB 0 B 0 B 0 B 15.33 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 29.91 KB 0 B 0 B 0 B 29.93 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.97 KB 0 B 0 B −187 B 9.98 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.40 KB 0 B 0 B 0 B 26.41 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.65 KB 0 B 0 B 0 B 32.66 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.77 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 33.89 KB 0 B 0 B 0 B 33.91 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest) 39.30 KB 0 B 0 B 0 B 39.32 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.83 KB 0 B 0 B 0 B 35.84 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 43.29 KB 0 B 0 B 0 B 43.30 KB ✅ eager (counted): web.js 23.13 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.35 KB 0 B 0 B 0 B 41.36 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.14 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 48.99 KB 0 B 0 B 0 B 49.00 KB ✅ eager (counted): client.js 28.31 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.14 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer) 1.27 KB 0 B 0 B 0 B 1.29 KB ✅
server: renderToString (the server-render floor) 22.85 KB 0 B 0 B 0 B 22.87 KB ✅

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@ryansolid
ryansolid merged commit a666dbd into next Nov 2, 2026
8 checks passed
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 41416838381

Coverage remained the same at 78.205%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1369
Covered Lines: 1131
Line Coverage: 82.62%
Relevant Branches: 1104
Covered Branches: 803
Branch Coverage: 72.74%
Branches in Coverage %: Yes
Coverage Strength: 29.98 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Nov 2, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

2 warnings

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 198 untouched benchmarks
⏩ 5 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ memo + sync render effect only (reference) 29.2 ms 34.7 ms -15.79%
⚡ projection derive: write one NESTED field (reference) 2.7 ms 2.1 ms +27.52%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/size-ledger-after-4611 (d0acd11) with next (97e1826)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ryansolid
ryansolid deleted the claude/size-ledger-after-4611 branch November 5, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants