test: pin `Loading on` after an action-held input change (#4605) by ryansolid · Pull Request #4609 · solidjs/solid

ryansolid · 2026-11-02T07:25:13Z

Tests only. Refs #4605.

What

#4605 reports that after an input change was held by an action (D-34, #4336), a later input change with nothing in flight does not show <Loading on={filter()}>'s fallback, while the same change without on does.

On current next the two cases behave the other way round, which is what the rules ask for:

With on: the change arms the boundary and shows loading (F-5, D-15).
Without on: the already shown boundary forwards, so the change keeps the old list until the answer lands (F-5).

This holds in dev and prod conditions and with both compilers. The issue's reported frames look swapped between the two cases.

Tests

packages/web/test/loading-on-held-change-4605.spec.tsx: the issue's repro with its frames asserted for both cases.
packages/signals/tests/loading-on-held-change-4605.test.ts: a signals-only version of the same scenario.

No source changes, no size change.

Generated by Claude Code

A keyed optimistic list asked by `filter()`; an action guesses, yields, then refreshes; a `filter` write while the action is out is held with it (D-34, #4336). After everything rests, a second `filter` write with nothing in flight arms `<Loading on={filter()}>` and shows the fallback with that change's frame (F-5, D-15). Without `on` the shown boundary forwards and the change holds the old list until the answer (F-5). Current `next` already behaves this way, in dev and prod conditions and with both compilers: the issue's reported frames have the two cases swapped. These pins (the issue's web spec with asserted frames, plus a signals-only twin) keep it so. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

changeset-bot · 2026-11-02T07:25:25Z

⚠️ No Changeset found

Latest commit: c25e809

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-11-02T07:28:31Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	−91 B	7.43 KB	✅
signals: + createStore	15.00 KB	+15 B	15.01 KB	✅
signals: + isPending/latest	11.45 KB	+15 B	11.47 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	−84 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.80 KB	−150 B	9.80 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.81 KB	−163 B	18.80 KB	⚠️ over by 7 B, 183 B minified headroom	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.75 KB	+15 B	32.77 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.52 KB	+15 B	13.52 KB	⚠️ over by 3 B, 5 B minified headroom	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.26 KB	+15 B	15.26 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.83 KB	−140 B	29.88 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	−187 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.32 KB	−198 B	26.36 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.55 KB	−204 B	32.61 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.90 KB	+10 B	33.83 KB	⚠️ over by 71 B, 10 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	39.28 KB	+15 B	39.31 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.77 KB	+13 B	35.77 KB	⚠️ over by 2 B, 7 B minified headroom	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	43.23 KB	+15 B	43.24 KB	✅	eager (counted): web.js 23.07 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.21 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.28 KB	+180 B	41.33 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.14 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.93 KB	+166 B	48.93 KB	✅	eager (counted): client.js 28.25 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.14 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.85 KB	0 B	22.87 KB	✅

⚠️ Over the brotli cap within the minified allowance (passes)

app: hydrating (no stores) with Show/For/Loading/Errored/lazy: over brotli cap by 7 B; minified 53,454 B vs 53,617 B recorded with the cap (−163 B) — 183 B of the 20 B minified allowance left; +0 B minified over this PR's base
app: CSR with Show/For/Loading/Errored/lazy: over brotli cap by 3 B; minified 36,924 B vs 36,909 B recorded with the cap (+15 B) — 5 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: base server components (hydrating + dynamic + frames + sf reference): over brotli cap by 71 B; minified 101,579 B vs 101,569 B recorded with the cap (+10 B) — 10 B of the 20 B minified allowance left; +0 B minified over this PR's base
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread): over brotli cap by 2 B; minified 107,913 B vs 107,900 B recorded with the cap (+13 B) — 7 B of the 20 B minified allowance left; +0 B minified over this PR's base

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-11-02T07:37:41Z

Coverage Report for CI Build 41406190194

Coverage remained the same at 78.205%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1369
Covered Lines:	1131
Line Coverage:	82.62%
Relevant Branches:	1104
Covered Branches:	803
Branch Coverage:	72.74%
Branches in Coverage %:	Yes
Coverage Strength:	30.09 hits per line

💛 - Coveralls

codspeed · 2026-11-02T07:41:16Z

Merging this PR will degrade performance by 2.46%

2 warnings

⚠️ 3 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 3 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 197 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`arrow in template`	10.9 ms	12.7 ms	-14.01%
❌	`memo + sync render effect only (reference)`	30.3 ms	32.3 ms	-6.29%
⚡	`reconcile: deep tree, single deep() effect`	95.9 ms	83.3 ms	+15.15%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/fix-4605-loading-on-held (c25e809) with next (551ef0d)²}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on next (9379257) during the generation of this report, so 551ef0d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ryansolid · 2026-11-02T07:41:22Z

The red CodSpeed check isn't caused by this PR. The PR only adds test files and changes no source, so it can't move any benchmark. The flagged benches, including "arrow in template", are the known noisy ones, and CodSpeed notes that base and head ran on different hardware.

Generated by Claude Code

ryansolid mentioned this pull request Nov 2, 2026

[2.0 / next] Loading on stops showing its fallback for an input change after an earlier change was held by an action #4605

Closed

ryansolid merged commit 2abd9a2 into next Nov 2, 2026
8 of 9 checks passed

ryansolid mentioned this pull request Nov 2, 2026

fix(signals): a fresh Loading waits on the hold its content derives from (#4593, #4591) #4611

Merged

ryansolid deleted the claude/fix-4605-loading-on-held branch November 5, 2026 17:33

Navigation Menu

Repository navigation

test: pin `Loading on` after an action-held input change (#4605) - #4609

test: pin `Loading on` after an action-held input change (#4605)#4609
ryansolid merged 1 commit into
nextfrom
claude/fix-4605-loading-on-held

ryansolid commented Nov 2, 2026

Uh oh!

changeset-bot Bot commented Nov 2, 2026

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

coveralls commented Nov 2, 2026

Uh oh!

codspeed Bot commented Nov 2, 2026

Uh oh!

ryansolid commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Nov 2, 2026

What

Tests

Uh oh!

changeset-bot Bot commented Nov 2, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Nov 2, 2026

Size (brotli, eager entry chunk)

⚠️ Over the brotli cap within the minified allowance (passes)

Uh oh!

coveralls commented Nov 2, 2026

Coverage Report for CI Build 41406190194

Coverage remained the same at 78.205%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Nov 2, 2026

Merging this PR will degrade performance by 2.46%

Performance Changes

Footnotes

Uh oh!

ryansolid commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants