chore(size): re-record the ledger after #4511 and for #4510 by ryansolid · Pull Request #4521 · solidjs/solid

ryansolid · 2026-10-31T04:27:00Z

Before: next @ 6bde511 has four rows over their brotli cap after #4511, though each is within the 20 B minified allowance. Those rows are hydrating no-stores (+43 B), base server components (+29 B), compiled live server components (+11 B) and observe + attribution (+4 B). #4510's size check is red on five rows.

After: the ledger records the post-#4511 sizes, plus #4510's growth, which the maintainer accepted on 2026-10-31. #4510 goes green once next is merged into it.

How: I measured next @ 6bde511 and #4510 with next merged in (bc3dfdf). For each row I took the larger of the two. Caps are measured brotli + 10 B, rounded up to 0.01 KB. Rows that are only past the minified allowance re-record minified and keep their caps. The local size.mjs gate passes on both builds with this ledger. The local #4510 numbers match its CI run on 5429aa0.

Row	Cap	Recorded minified	Cause
signals: + isPending/latest	11.35 → 11.40 KB	31,260 → 31,328	#4510
app: hydrating + every store	32.48 → 32.51 KB	98,561 → 98,648	#4510
page: compiled live SC	43.02 → 43.06 KB	126,196 → 126,293	#4511 + #4510
page: live + router	48.67 → 48.69 KB	143,527 → 143,570	#4510
page: live SC (frozen)	unchanged 39.10 KB	118,048 → 118,123	#4510
app: hydrating (no stores) (frozen)	18.74 → 18.80 KB	53,607 → 53,611	#4511
page: base SC (frozen)	33.77 → 33.81 KB	101,706 → 101,710	#4511
app: CSR, observe + attribution	29.78 → 29.80 KB	88,316 → 88,329	#4511
signals: + createStore	unchanged	43,956 → 43,980	#4511
app: compiled CSR	unchanged	80,074 → 80,106	#4511
app: compiled hydrating	unchanged	100,836 → 100,868	#4511

Hello world is unchanged and stays under its 9.98 KB cap.

Size-Exception: frozen floors hydrating (no stores), base server components and live server components are re-recorded for #4511 (merged 2026-10-30) and #4510; the maintainer accepted that growth on 2026-10-30 and 2026-10-31.

Generated by Claude Code

Re-records the rows #4511 left over cap or more than 20 B minified past the ledger on next @ 6bde511, and records #4510's growth (accepted by the maintainer, 2026-10-31) so it merges green once next is merged into it. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-31T04:27:04Z

⚠️ No Changeset found

Latest commit: 204e342

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-31T04:29:55Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.41 KB	−3 B	7.43 KB	✅
signals: + createStore	14.97 KB	0 B	14.99 KB	✅
signals: + isPending/latest	11.34 KB	−71 B	11.40 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.04 KB	−1 B	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.79 KB	−3 B	9.80 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.78 KB	0 B	18.80 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.43 KB	−38 B	32.51 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.43 KB	+13 B	13.47 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.18 KB	+13 B	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.78 KB	0 B	29.80 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.98 KB	−1 B	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.30 KB	0 B	26.36 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.50 KB	0 B	32.54 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.80 KB	0 B	33.81 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.19 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	39.08 KB	−71 B	39.10 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.18 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.69 KB	+4 B	35.72 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.15 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	43.03 KB	−93 B	43.06 KB	✅	eager (counted): web.js 23.01 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.17 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.10 KB	−53 B	41.25 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.13 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.63 KB	−112 B	48.69 KB	✅	eager (counted): client.js 28.12 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.13 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	0 B	1.29 KB	✅
server: renderToString (the server-render floor)	22.85 KB	0 B	22.87 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-31T04:36:41Z

Coverage Report for CI Build 41168615948

Coverage remained the same at 78.108%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1363
Covered Lines:	1126
Line Coverage:	82.61%
Relevant Branches:	1090
Covered Branches:	790
Branch Coverage:	72.48%
Branches in Coverage %:	Yes
Coverage Strength:	29.88 hits per line

💛 - Coveralls

codspeed · 2026-10-31T04:51:24Z

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 200 untouched benchmarks
⏩ 5 skipped benchmarks¹

_{Comparing claude/project-thread-x1ore2-ledger-6bde511 (204e342) with next (6bde511)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

ryansolid merged commit 730c9ef into next Oct 31, 2026
8 checks passed

ryansolid deleted the claude/project-thread-x1ore2-ledger-6bde511 branch November 5, 2026 17:34

Navigation Menu

Repository navigation

chore(size): re-record the ledger after #4511 and for #4510 - #4521

chore(size): re-record the ledger after #4511 and for #4510#4521
ryansolid merged 1 commit into
nextfrom
claude/project-thread-x1ore2-ledger-6bde511

ryansolid commented Oct 31, 2026

Uh oh!

changeset-bot Bot commented Oct 31, 2026

Uh oh!

github-actions Bot commented Oct 31, 2026

Uh oh!

Uh oh!

coveralls commented Oct 31, 2026

Uh oh!

codspeed Bot commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 31, 2026

Uh oh!

changeset-bot Bot commented Oct 31, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 31, 2026

Size (brotli, eager entry chunk)

Uh oh!

Uh oh!

coveralls commented Oct 31, 2026

Coverage Report for CI Build 41168615948

Coverage remained the same at 78.108%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 31, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants