chore: a seat-shadow build can't be published; the carve brief points at its stop by ryansolid · Pull Request #4448 · solidjs/solid

ryansolid · 2026-10-30T08:24:37Z

Summary

Before: a @solidjs/signals dist built with SIGNALS_TEST_DEFINE=true carries the reader-seat shadow, about 1.7 KB of __SEAT_SHADOW__ and shadowRead in dist/dev-shared.js. Nothing in the release path noticed, and tests/dist-artifacts.test.ts passes on such a build. Separately, documentation/plans/reader-seat-brief.md §4 still describes "rebuild beside, then swap" as the plan, with no sign that the swap stopped.

After: scripts/verify-release-artifacts.mjs fails a release whose tarball carries __SEAT_SHADOW__. release.mjs runs this script before it publishes anything. Brief §4 opens with a stop note pointing at reader-seat-rebuild.md §8, which records the S1 result and supersedes §4.

These are follow-ups from #4438's review.

How

The check reads every .js/.mjs/.cjs file in each fixed package's dry-run tarball list and looks for __SEAT_SHADOW__, the global the shadow installs its report sink on (core/seat.ts).
I left dist-artifacts.test.ts alone, because the differential workflow runs the suites on a shadow build on purpose.
No runtime code changes, so the size and bench effect is 0 B.

How did you test this change?

I built @solidjs/signals twice and ran the check's filter over the npm pack --dry-run --json file list:

With SIGNALS_TEST_DEFINE=true, it flags dist/dev-shared.js.
With a plain build, it flags nothing.

The full script's npm publish --dry-run step can't run locally, because rc.20 is already on npm and the local npm prints a different --json shape. The release workflow runs it on the version-bumped commit. Prettier is clean on both files.

Generated by Claude Code

… at its stop Follow-ups from #4438's review. - verify-release-artifacts.mjs (run by release.mjs before anything is published) fails when a fixed package's tarball carries `__SEAT_SHADOW__`, the mark a SIGNALS_TEST_DEFINE=true build leaves in @solidjs/signals' dist/dev-shared.js. A shadow build is a test build (rollup.config.js: "never for measuring or publishing"). - reader-seat-brief.md §4 says the swap stopped and points at reader-seat-rebuild.md §8, which supersedes it. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-30T08:24:44Z

⚠️ No Changeset found

Latest commit: 227517d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-30T08:28:34Z

Size (brotli, eager entry chunk)

scenario	head	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	7.43 KB	✅
signals: + createStore	14.88 KB	14.89 KB	✅
signals: + isPending/latest	11.03 KB	11.04 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.04 KB	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.77 KB	9.78 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.73 KB	18.74 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.42 KB	32.42 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.42 KB	13.43 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.19 KB	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.73 KB	29.74 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.96 KB	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.26 KB	26.27 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.42 KB	32.43 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.65 KB	33.66 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	38.73 KB	38.74 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.65 KB	35.66 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.99 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	42.64 KB	42.65 KB	✅	eager (counted): web.js 22.75 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.07 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.22 KB	41.23 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.57 KB, trace.js 9.02 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.37 KB	48.38 KB	✅	eager (counted): client.js 27.95 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.00 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	1.29 KB	✅
server: renderToString (the server-render floor)	22.79 KB	22.80 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

…-x1ore2-seat-release-guard

coveralls · 2026-10-30T08:40:17Z

Coverage Report for CI Build 41026749382

Coverage remained the same at 78.1%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1362
Covered Lines:	1125
Line Coverage:	82.6%
Relevant Branches:	1090
Covered Branches:	790
Branch Coverage:	72.48%
Branches in Coverage %:	Yes
Coverage Strength:	29.82 hits per line

💛 - Coveralls

codspeed · 2026-10-30T08:49:38Z

Merging this PR will not alter performance

1 warning

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 200 untouched benchmarks
⏩ 5 skipped benchmarks¹

_{Comparing claude/project-thread-x1ore2-seat-release-guard (227517d) with next (b249ad9)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Merge remote-tracking branch 'origin/next' into claude/project-thread…

227517d

…-x1ore2-seat-release-guard

ryansolid merged commit 7384573 into next Oct 30, 2026
8 checks passed

ryansolid deleted the claude/project-thread-x1ore2-seat-release-guard branch November 5, 2026 17:34

Navigation Menu

Repository navigation

chore: a seat-shadow build can't be published; the carve brief points at its stop - #4448

chore: a seat-shadow build can't be published; the carve brief points at its stop#4448
ryansolid merged 2 commits into
nextfrom
claude/project-thread-x1ore2-seat-release-guard

ryansolid commented Oct 30, 2026

Uh oh!

changeset-bot Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

coveralls commented Oct 30, 2026

Uh oh!

codspeed Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 30, 2026

Summary

How

How did you test this change?

Uh oh!

changeset-bot Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size (brotli, eager entry chunk)

Uh oh!

Uh oh!

coveralls commented Oct 30, 2026

Coverage Report for CI Build 41026749382

Coverage remained the same at 78.1%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented Oct 30, 2026 •

edited

Loading

github-actions Bot commented Oct 30, 2026 •

edited

Loading

codspeed Bot commented Oct 30, 2026 •

edited

Loading