chore(size): re-record the ledger on next @ 5d57e12 after #4418 and #4414 by ryansolid · Pull Request #4421 · solidjs/solid

ryansolid · 2026-10-29T17:16:19Z

Summary

Before: the Size check is red on next @ 5d57e12. #4414's truncation sweep adds about 100 B minified to solid's hydration client, which pushes three server-component pages over their caps: the live page (+69 B brotli), the compiled base page (+20 B) and the compiled live page (+20 B). Every open PR inherits the red check, including #4409 and #4411.

After: every cap sits at CI brotli + 10 B, rounded up to 0.01 KB, and every recorded minified equals the CI measurement on next @ 5d57e12 (size job 123602802067). The Size check is green on next.

Changes

Lowered: perf(signals): fold verdict and lane upkeep out of builds without those engines #4418's floor trim lowers 15 caps. Hello world goes 10.07 → 9.98 KB, so the gate now enforces the 10 KB stop. The core floor goes 7.53 → 7.43 KB, the simple-app floor 9.88 → 9.79 KB, hydrating 18.80 → 18.72 KB, page base 33.78 → 33.68 KB and base + router 41.32 → 41.16 KB.
Raised (fix(solid): a truncated fragment's fresh render computes what the server never sent #4414):
- Live page, a frozen floor: 38.67 → 38.75 KB, minified 116,986 → 117,124 B.
- Compiled base page: 35.69 → 35.72 KB.
- Compiled live page: 42.62 → 42.65 KB, minified 125,165 → 125,266 B.
- live + router: recorded minified 142,427 → 142,528 B, cap unchanged.

The minified allowance still covers the open PRs. #4409 adds 7 B minified over this base.

Size-Exception: #4414's truncated-fragment fix (+~100 B minified in the hydration client) was merged on the maintainer's go (2026-10-29); the live page floor follows it.

How did you test this change?

npm test in scripts/size passes, and prettier is clean.
Checked every scenario's CI measurement on 5d57e12 against the new caps: all 22 are at or under their cap and recorded minified.

Generated by Claude Code

…4414 Caps at CI brotli + 10 B rounded up to 0.01 KB, recorded minified = CI measured (next @ 5d57e12, size job 123602802067). #4418's floor trim lowers most caps; #4414's truncation sweep (+~100 B minified in solid's hydration client) raises the compiled base page, the compiled live page and live + router's recorded minified. Hello world cap 10.07 -> 9.98 KB. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Size-Exception in the PR body: the live page grows with #4414; the other floors drop with #4418. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-29T17:16:30Z

⚠️ No Changeset found

Latest commit: 8a44601

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-29T17:19:14Z

Size (brotli, eager entry chunk)

scenario	head	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	7.43 KB	✅
signals: + createStore	14.95 KB	14.96 KB	✅
signals: + isPending/latest	11.04 KB	11.05 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.78 KB	9.79 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.70 KB	18.72 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.40 KB	32.42 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.42 KB	13.43 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.19 KB	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.77 KB	29.79 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.29 KB	26.31 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.45 KB	32.46 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.66 KB	33.68 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	38.74 KB	38.75 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.71 KB	35.72 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.99 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	42.64 KB	42.65 KB	✅	eager (counted): web.js 22.76 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.07 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.15 KB	41.16 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.57 KB, trace.js 9.02 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.29 KB	48.31 KB	✅	eager (counted): client.js 27.88 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.00 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	1.29 KB	✅
server: renderToString (the server-render floor)	22.79 KB	22.80 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-29T17:24:16Z

Coverage Report for CI Build 40919727020

Coverage remained the same at 78.259%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1359
Covered Lines:	1125
Line Coverage:	82.78%
Relevant Branches:	1088
Covered Branches:	790
Branch Coverage:	72.61%
Branches in Coverage %:	Yes
Coverage Strength:	29.88 hits per line

💛 - Coveralls

codspeed · 2026-10-29T17:41:20Z

Merging this PR will degrade performance by 10.53%

2 warnings

⚠️ 4 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 198 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`projection derive: write one NESTED field (reference)`	2.4 ms	2.7 ms	-11.61%
❌	`arrow in template`	11.2 ms	12.4 ms	-9.45%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-x1ore2-size-ledger-4414 (8a44601) with next (5d57e12)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

claude added 2 commits October 29, 2026 17:15

This was referenced Oct 29, 2026

fix(signals): an own-error memo's landing re-derive runs before the held effects (#4407) #4409

Merged

test(signals): pin #4402 and #4398 as fixed by #4393; #4399 as a carve row #4411

Merged

ryansolid merged commit 69a55df into next Oct 29, 2026
8 checks passed

This was referenced Oct 31, 2026

fix(signals): a released memo's queued retry runs before the release (#4474) #4535

Merged

fix: core batch — #4474 lazy-memo catch-up (#4417 display-ahead attach left out; no cap adjustment) #4545

Closed

ryansolid deleted the claude/project-thread-x1ore2-size-ledger-4414 branch November 5, 2026 17:34

Navigation Menu

Repository navigation

chore(size): re-record the ledger on next @ 5d57e12 after #4418 and #4414 - #4421

chore(size): re-record the ledger on next @ 5d57e12 after #4418 and #4414#4421
ryansolid merged 2 commits into
nextfrom
claude/project-thread-x1ore2-size-ledger-4414

ryansolid commented Oct 29, 2026

Uh oh!

changeset-bot Bot commented Oct 29, 2026

Uh oh!

github-actions Bot commented Oct 29, 2026

Uh oh!

Uh oh!

coveralls commented Oct 29, 2026

Uh oh!

codspeed Bot commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 29, 2026

Summary

Changes

How did you test this change?

Uh oh!

changeset-bot Bot commented Oct 29, 2026

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 29, 2026

Size (brotli, eager entry chunk)

Uh oh!

Uh oh!

coveralls commented Oct 29, 2026

Coverage Report for CI Build 40919727020

Coverage remained the same at 78.259%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

codspeed Bot commented Oct 29, 2026

Merging this PR will degrade performance by 10.53%

Performance Changes

Footnotes

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants