test(signals): pin #4402 and #4398 as fixed by #4393; #4399 as a carve row by ryansolid · Pull Request #4411 · solidjs/solid

ryansolid · 2026-10-29T10:40:29Z

Summary

Before: #4393 fixed #4402 and the shapes reported in #4398, but nothing pinned them. #4399's remaining duplicate ask had no pin.

After: packages/signals/tests/latest-first-one-pass-4402.test.ts pins:

2.0: a pass that reads latest(s) before s() computes twice on a plain write #4402: [latest(s), s()] and [s(), latest(s)] compute once per plain write, with a render effect, memo or user effect as the reader (D-22). The latest-first rows fail on next before fix(signals): latest() opens no transaction for its verdict; its reader watches the seam (#4365) #4393.
2.0: grouping isPending(x) with x() in one effect changes which lanes a later write opens #4398: a change during the hold shows 5 → 8 → 10 whether [isPending(m1), m1()] is grouped in one effect, split across two, or m1() is read alone (D-26, F-6, [2.0 / next] A held optimistic lane holds per render effect: latest(x) in its own JSX hole shows the guess beside held content (D-25) #4284). The value-alone shape skipped 8 before fix(signals): latest() opens no transaction for its verdict; its reader watches the seam (#4365) #4393.
2.0: an async memo over two held verdict sources asks the same lane question twice #4399 (it.fails, a reader-seat carve row): two actions, each holding a verdict memo's write, ask m1:15 twice in the split and value shapes. One ask is in A's verdict lane and one is in B's transaction, over the same inputs (F-9). Telling the passes apart needs a per-pass check. The pair shape asks once and is a plain it.

How did you test this change?

On next 81a12d8: 10 passed, 2 expected fail, stable across runs. rules-index current.

Generated by Claude Code

…e row Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

changeset-bot · 2026-10-29T10:40:35Z

⚠️ No Changeset found

Latest commit: 051f1ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-10-29T10:43:47Z

Size (brotli, eager entry chunk)

scenario	head	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.42 KB	7.43 KB	✅
signals: + createStore	14.95 KB	14.96 KB	✅
signals: + isPending/latest	11.04 KB	11.05 KB	✅
signals: + until/refresh (truth readers, no optimism)	8.05 KB	8.06 KB	✅
app: render + one signal (the simple-app floor)	9.78 KB	9.79 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.70 KB	18.72 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	32.40 KB	32.42 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.42 KB	13.43 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.19 KB	15.20 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.77 KB	29.79 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.97 KB	9.98 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.29 KB	26.31 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.45 KB	32.46 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	11.77 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.66 KB	33.68 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: live server components (base + live/GET + action + isPending/latest)	38.74 KB	38.75 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.03 KB, wire.js 3.47 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.71 KB	35.72 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 8.99 KB, wire.js 3.47 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	42.64 KB	42.65 KB	✅	eager (counted): web.js 22.76 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.07 KB, sc-comments.js 0.19 KB, trace.js 9.07 KB, wire.js 3.47 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	41.15 KB	41.16 KB	✅	assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.03 KB, serverForms.js 3.57 KB, trace.js 9.02 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	48.29 KB	48.31 KB	✅	eager (counted): client.js 27.88 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.30 KB, trace.js 9.00 KB, wire.js 3.49 KB
server: floor (getRequestEvent + isServer)	1.27 KB	1.29 KB	✅
server: renderToString (the server-render floor)	22.79 KB	22.80 KB	✅

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

codspeed · 2026-10-29T10:59:55Z

Merging this PR will regress 1 benchmark

2 warnings

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 197 untouched benchmarks
⏩ 5 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`projection derive: write one NESTED field (reference)`	2.1 ms	2.7 ms	-21.4%
⚡	`createStore setter: delete + set one root key (#3044 overlay)`	2.1 ms	1.8 ms	+16.21%
⚡	`arrow in template`	12.4 ms	11.1 ms	+11.88%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing claude/project-thread-x1ore2-carve-pins (051f1ae) with next (0f5b150)²}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on next (69a55df) during the generation of this report, so 0f5b150 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

The change-during-hold pin raced the flights under coverage on CI ([7, 10] for [5, 8, 10]); the script's order now decides it. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

ryansolid · 2026-10-29T11:21:40Z

The size check is red because next itself is over the ledger after the 2026-10-29 batch. This PR changes only tests. The report's "vs base" column is against an older base; after a merge of current next it would read 0 B. #4412 re-records the ledger on next, and once it merges I'll merge next into this branch.

Generated by Claude Code

coveralls · 2026-10-29T11:25:33Z

Coverage Report for CI Build 40920938347

Coverage remained the same at 78.259%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1359
Covered Lines:	1125
Line Coverage:	82.78%
Relevant Branches:	1088
Covered Branches:	790
Branch Coverage:	72.61%
Branches in Coverage %:	Yes
Coverage Strength:	29.72 hits per line

💛 - Coveralls

ryansolid · 2026-10-29T11:29:31Z

The CodSpeed dip on projection derive: write one NESTED field (reference) (−12.6%) is noise. This PR changes only test files, so no benchmarked code is different. CodSpeed also says base and head ran on different runner types. That benchmark swings ±13–15% with module layout alone.

Generated by Claude Code

…-x1ore2-carve-pins

ryansolid · 2026-10-29T17:16:28Z

If the Size check goes red here, it isn't from this PR, which only changes tests. next @ 5d57e12 is red on three server-component pages after #4414. The fix is the ledger re-record in #4421. Once it lands I'll merge next here again.

Generated by Claude Code

…-x1ore2-carve-pins

test(signals): pin #4402 and #4398 as fixed by #4393; #4399 as a carv…

9abf0b8

…e row Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Merge remote-tracking branch 'origin/next' into claude/project-thread…

912c4e1

…-x1ore2-carve-pins

ryansolid mentioned this pull request Oct 29, 2026

chore(size): re-record the ledger on next @ 5d57e12 after #4418 and #4414 #4421

Merged

Merge remote-tracking branch 'origin/next' into claude/project-thread…

051f1ae

…-x1ore2-carve-pins

ryansolid merged commit ddf3c4f into next Oct 29, 2026
8 checks passed

ryansolid deleted the claude/project-thread-x1ore2-carve-pins branch November 5, 2026 17:34

Navigation Menu

Repository navigation

test(signals): pin #4402 and #4398 as fixed by #4393; #4399 as a carve row - #4411

test(signals): pin #4402 and #4398 as fixed by #4393; #4399 as a carve row#4411
ryansolid merged 4 commits into
nextfrom
claude/project-thread-x1ore2-carve-pins

ryansolid commented Oct 29, 2026

Uh oh!

changeset-bot Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

ryansolid commented Oct 29, 2026

Uh oh!

coveralls commented Oct 29, 2026 •

edited

Loading

Uh oh!

ryansolid commented Oct 29, 2026

Uh oh!

ryansolid commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 29, 2026

Summary

How did you test this change?

Uh oh!

changeset-bot Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size (brotli, eager entry chunk)

Uh oh!

codspeed Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will regress 1 benchmark

Performance Changes

Footnotes

Uh oh!

ryansolid commented Oct 29, 2026

Uh oh!

coveralls commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 40920938347

Coverage remained the same at 78.259%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

ryansolid commented Oct 29, 2026

Uh oh!

ryansolid commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented Oct 29, 2026 •

edited

Loading

github-actions Bot commented Oct 29, 2026 •

edited

Loading

codspeed Bot commented Oct 29, 2026 •

edited

Loading

coveralls commented Oct 29, 2026 •

edited

Loading