produce causes TS error #732

Activity

1. ryansolid

   added

   typescriptrelating to typescript or typesrelating to typescript or types

   PRs WelcomeAn issue which might not be prioritized right away but would be open to community contributionAn issue which might not be prioritized right away but would be open to community contribution

   on Nov 16, 2021
2. mac-ignacio commented on Nov 26, 2021

   

   mac-ignacio

   on Nov 26, 2021

   More actions

   It's not actually an error. You are just missing some interface for produce. Add a Count interface and provide it as a generic type for produce like the code below.

   interface Count {
     count: number;
   }
   
   function Counter() {
     const [store, setStore] = createStore({ count: 0 });
   
     const increment = () => {
       setStore(
         produce<Count>((s) => {
           s.count++;
         })
       );
     };
     return (
       <button type="button" onClick={increment}>
         {store.count}
       </button>
     );
   }

   👍React with 👍1Reacted by David Di Biase
3. bgoscinski commented on Nov 26, 2021

   

   bgoscinski

   on Nov 26, 2021

   Last edited by bgoscinski

   Author

   More actions

   Thanks @mackignacio!
   While your solution works I assumed that the original intent was that explicit interface should not be necessary because TS should be able to infer the types. This would greatly improve the ergonomics of produce.

   @ryansolid is my assumption correct?
   In any case please treat this ticket as a request for making the generic optional (inferable) :)

   I tried to dig into the types of produce and setStore and fix it myself but oh boy they're complex lol
4. davedbase commented on Nov 26, 2021

   

   davedbase

   on Nov 26, 2021

   Last edited by davedbase

   Member

   More actions

   @trusktr has been reviewing our types maybe he has an opinion on this. Also lol...wait until you see some of the new TS types coming. Weeeee

   😄React with 😄2Reacted by Bartosz Gościński and Renzo Cabarios
5. mac-ignacio commented on Nov 27, 2021

   

   mac-ignacio

   on Nov 27, 2021

   More actions

   @trusktr I can help with the types if needed. Just show me where to start.
6. trusktr commented on Dec 12, 2021

   

   trusktr

   on Dec 12, 2021

   Contributor

   More actions

   Indeed there are more places to take a stab at improving inference, plus making the source code itself more type safe. Just run Go To Definition in VS Code on produce and that'll take you right to it.
7. otonashixav

   added 12 commits that reference this issue on Dec 13, 2021

   feat(store): improve store types

   ...

   This issue will close once commit 1b5e244 is merged into the 'main' branch.

   1b5e244

   feat(store): improve store types

   ...

   This issue will close once commit 88d1020 is merged into the 'main' branch.

   88d1020

   refactor(store): improve store types

   ...

   This issue will close once commit 9ec867d is merged into the 'main' branch.

   9ec867d

   refactor(store): improve store types

   ...

   This issue will close once commit 95d063c is merged into the 'main' branch.

   95d063c

   refactor(store): improve store types

   ...

   This issue will close once commit 4826b9e is merged into the 'main' branch.

   4826b9e

   refactor(store): improve store types

   ...

   This issue will close once commit 8b29aee is merged into the 'main' branch.

   8b29aee

   refactor(store): improve store types

   ...

   This issue will close once commit 7447086 is merged into the 'main' branch.

   7447086

   refactor(store): improve store types

   ...

   This issue will close once commit f0e8b79 is merged into the 'main' branch.

   f0e8b79

   refactor(store): improve store types

   ...

   This issue will close once commit 8fe9da6 is merged into the 'main' branch.

   8fe9da6

   refactor(store): improve store types

   ...

   This issue will close once commit f97f3f3 is merged into the 'main' branch.

   f97f3f3

   refactor(store): improve store types

   ...

   This issue will close once commit 3222679 is merged into the 'main' branch.

   3222679

   refactor(store): improve store types

   ...

   This issue will close once commit 171468e is merged into the 'main' branch.

   171468e
8. ryansolid

   closed this as completedin #763on Jan 6, 2022
9. ryansolid

   added a commit that references this issue on Jan 6, 2022

   refactor(store): improve store types (#763)

   ...

   This issue will close once commit bdf39a7 is merged into the 'main' branch.

   bdf39a7
10. lilybw

    added a commit that references this issue on Nov 12, 2025

    refactor(store): improve store types (solidjs#763)

    ...

    This issue will close once commit c03923e is merged into the 'main' branch.

    c03923e