Repository navigation
Solid v2.0.0-beta.10 refresh() does not catch NotReadyError #2694
Description
Describe the bug
Calling refresh(optimistic) throws an error that comes from a NotReadyError from calling count() that should have been filtered out.
Your Example Website or App
Steps to Reproduce the Bug or Issue
- Go to the page
- Cllck on the button
- Check error in console
Expected behavior
NotReadyError should be filtered out
Screenshots or Videos
No response
Platform
- OS: aarch64 Linux
- Browser: Chromium
- Version: 147.0.7727.101
Additional context
No response
Reacted by Tetrafocal
Activity
fix(signals): prevent refresh from throwing pending reads (#2694)
ryansolid commentedon May 11, 2026
We fixed this but also changed its shape.. refresh only takes direct refreshable things like accessors/stores.. This required branded types that I'm not stoked about but it seems to work well enough: Fixed in beta.11
atk commentedon May 12, 2026
The exact same example run with beta.11 unfortunately still shows the exact same error if I click on the button.
mizulu commentedon May 12, 2026
@atk if you are basing the reproduction based on the
old playground then it is still failing because it does not use the correct @solidjs/signals version
it is better to use the playground in the new domain https://s.olid.uk
it has much better for version pinning, and has features to show when version mismatches exists
I did not update the netlifty one as to not impact old bug reports, but new bugs should use the newer maintained version.
https://s.olid.uk/id/BriJdHvXT2GMqgOaLgLwXg beta.11 ( does not throw )
https://s.olid.uk/id/tRO_aXgvRdOqxu7ALzrgyw beta.10 ( throws )
atk commentedon May 13, 2026
My bad, it was an issue with pnpm. It is solved now.