DEV build seems to have O(n^2) in registerGraph name resolution for createSignal in onMount when using signals from props #1322

Activity

1. LiQuidProQuo commented on Oct 31, 2022

   

   LiQuidProQuo

   on Oct 31, 2022

   Contributor

   More actions

   For Dev when a signal name is generated it uses a rather expensive method(serialization) to generate a hash which may also increase in complexity as the object grows

   solid/packages/solid/src/reactive/signal.ts

   Lines 1048 to 1078 in 454ed51

   	export function hashValue(v: any): string {
   	const s = new Set();
   	return `s${
   	typeof v === "string"
   	? hash(v)
   	: hash(
   	untrack(
   	() =>
   	JSON.stringify(v, (k, v) => {
   	if (typeof v === "object" && v != null) {
   	if (s.has(v)) return;
   	s.add(v);
   	const keys = Object.keys(v);
   	const desc = Object.getOwnPropertyDescriptors(v);
   	const newDesc = keys.reduce((memo, key) => {
   	const value = desc[key];
   	// skip getters
   	if (!value.get) memo[key] = value;
   	return memo;
   	}, {} as any);
   	v = Object.create({}, newDesc);
   	}
   	if (typeof v === "bigint") {
   	return `${v.toString()}n`;
   	}
   	return v;
   	}) || ""
   	)
   	)
   	}`;
   	}

   then if the hash already exists it will loop with an increment until a free name is found
   

   solid/packages/solid/src/reactive/signal.ts

   Line 1085 in 454ed51

   while (Owner.sourceMap[tryName]) tryName = `${name}-${++i}`;

   The good news is that it's a dev only feature, and performance testing should generally be done on a production build.
2. ryansolid commented on Oct 31, 2022

   

   ryansolid

   on Oct 31, 2022

   Member

   More actions

   Yeah I've been working with @thetarnav on figuring out if we can just remove all of this. It was an experiment.. seems sort of ill advised at this point. We've found otherways to make dev tools work better.
3. ryansolid

   added

   enhancementNew feature or requestNew feature or request

   on Nov 5, 2022
4. ryansolid

   added this to the 1.7.0 milestone on Mar 29, 2023
5. ryansolid

   closed this as completedon Mar 30, 2023