You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit fda83a3
Browse filesBrowse the repository at this point in the historyBrowse files
fix(signals): a chain's settle walk keeps the staged-error mark mid-hold (#4562) (#4582)
When a superseded flight's error is staged in a hold (D-41, `stageError`),
`settlePendingSource` retired each dependent's pending state on its first
arrival and only stage-marked a node it reached a second time. A diamond's
join is revisited and so carried the staging; a chain's join is reached
once, read as settled, and its view re-showed `false:3` while the hold was
still open. Graph shape was observable.
The walk now marks every node it fully settles from a staged error too, so
the chain shows the diamond's frames: `isPending` stays true until the
commit (F-9) and the screen keeps what it showed (F-2); the derivation of
a staged error carries it (D-41).
`stageMark` moves from core into the verdict engine (verdict.ts) behind a
new `stageMarkHook` installed by `installVerdictHooks`, so core carries
only the hook calls.
Spec: tests/settle-diamond-revisit.test.ts pins the chain alongside the
diamond.
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE
Co-authored-by: Claude <[email protected]>
A chain's verdict no longer flips to `false` mid-hold where a diamond's stays `true` (#4562). When a superseded flight's error is staged in a hold (D-41), the settle walk now marks every derivation it fully settles with the staging, not only a join it reaches a second time, so `isPending` stays `true` until the commit whatever the graph shape (F-9, F-2). The mark moved behind the verdict engine's hooks (`installVerdictHooks`), so builds without `isPending`/`latest` carry none of it.
0 commit comments