Repository navigation
Commit f1929d6
committed
fix(solid): hydrate an errored boundary's content in the pass (#4273)
Replaces the re-run at hydration end. When the server sent an error, the
boundary runs its content in the hydration pass with its data adopted by
id and no DOM claimed under it (`_uc`, read by isClaiming), so nothing
the server answered is fetched again and the fallback claims the
server's markup. A content that fails on the client holds that error and
tracks its inputs. A content that runs clean keeps the server's fallback
and error up behind a hold, ended by reset() or the content re-running.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf21 parent 2c2a912 commit f1929d6
4 files changed
Lines changed: 341 additions & 41 deletions
File tree
- .changeset
- packages
- solid
- src/client
- test
- web/test/hydration
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
307 | 310 | | |
308 | | - | |
| 311 | + | |
309 | 312 | | |
310 | 313 | | |
| 314 | + | |
311 | 315 | | |
312 | 316 | | |
313 | 317 | | |
314 | | - | |
| 318 | + | |
315 | 319 | | |
316 | 320 | | |
317 | 321 | | |
| |||
421 | 425 | | |
422 | 426 | | |
423 | 427 | | |
| 428 | + | |
424 | 429 | | |
425 | 430 | | |
426 | 431 | | |
| |||
1276 | 1281 | | |
1277 | 1282 | | |
1278 | 1283 | | |
1279 | | - | |
1280 | | - | |
1281 | | - | |
1282 | | - | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
1283 | 1291 | | |
1284 | | - | |
1285 | | - | |
1286 | | - | |
1287 | | - | |
1288 | | - | |
1289 | | - | |
1290 | | - | |
1291 | | - | |
1292 | | - | |
1293 | | - | |
1294 | | - | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
1295 | 1319 | | |
1296 | 1320 | | |
1297 | 1321 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| 95 | + | |
95 | 96 | | |
96 | | - | |
| 97 | + | |
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
| |||
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
134 | | - | |
| 135 | + | |
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
138 | 139 | | |
| 140 | + | |
139 | 141 | | |
140 | 142 | | |
141 | | - | |
| 143 | + | |
142 | 144 | | |
143 | 145 | | |
144 | 146 | | |
| |||
178 | 180 | | |
179 | 181 | | |
180 | 182 | | |
181 | | - | |
| 183 | + | |
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
| |||
203 | 205 | | |
204 | 206 | | |
205 | 207 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
| 208 | + | |
| 209 | + | |
212 | 210 | | |
213 | 211 | | |
214 | 212 | | |
215 | 213 | | |
| 214 | + | |
216 | 215 | | |
217 | 216 | | |
218 | 217 | | |
219 | 218 | | |
220 | 219 | | |
221 | 220 | | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
222 | 248 | | |
223 | 249 | | |
224 | 250 | | |
| |||
230 | 256 | | |
231 | 257 | | |
232 | 258 | | |
233 | | - | |
| 259 | + | |
234 | 260 | | |
235 | 261 | | |
236 | 262 | | |
237 | 263 | | |
| 264 | + | |
238 | 265 | | |
239 | | - | |
| 266 | + | |
240 | 267 | | |
241 | 268 | | |
242 | 269 | | |
| |||
336 | 363 | | |
337 | 364 | | |
338 | 365 | | |
339 | | - | |
| 366 | + | |
340 | 367 | | |
341 | 368 | | |
342 | 369 | | |
343 | 370 | | |
| 371 | + | |
344 | 372 | | |
345 | | - | |
| 373 | + | |
346 | 374 | | |
347 | 375 | | |
348 | 376 | | |
| |||
359 | 387 | | |
360 | 388 | | |
361 | 389 | | |
362 | | - | |
| 390 | + | |
363 | 391 | | |
364 | 392 | | |
365 | 393 | | |
366 | 394 | | |
| 395 | + | |
367 | 396 | | |
368 | 397 | | |
369 | 398 | | |
370 | 399 | | |
371 | | - | |
| 400 | + | |
372 | 401 | | |
373 | 402 | | |
374 | 403 | | |
| |||
510 | 539 | | |
511 | 540 | | |
512 | 541 | | |
513 | | - | |
| 542 | + | |
514 | 543 | | |
515 | 544 | | |
516 | 545 | | |
| |||
556 | 585 | | |
557 | 586 | | |
558 | 587 | | |
559 | | - | |
560 | | - | |
561 | | - | |
562 | | - | |
| 588 | + | |
563 | 589 | | |
564 | | - | |
565 | 590 | | |
566 | 591 | | |
567 | 592 | | |
| |||
0 commit comments