Repository navigation
Commit edc407f
committed
fix(signals): keep the #4536 observation in the optimistic store's hook, off the plain store path
The size job put the guard and the split-binding check on every store's
family read (+202 B minified on plain createStore). They now live in
optimistic.ts's `stands` hook, which only an optimistic family installs:
a reader linked to the flight is not served the guesses (the
contributor's guard), and a render effect pending on a flight the guess
was written over (the #4525 mark, `fam.g`) is read as `pullFamily`'s own
read would. `pullFamily` asks `stands` before the frame guard (the same
outcomes for every reader, so the hook sees unlinked render effects) and
`linkedTo` walks the derive's subscribers.
The split test drops the memo-between-list-and-binding variant: holding
that memo kept it pending, so `<For>` stopped showing the guess over the
old answer (the #4525 web spec, `open: [#3][#4]`), which CI caught.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf21 parent 5bcd2cb commit edc407f
4 files changed
Lines changed: 48 additions & 55 deletions
File tree
- packages/signals
- src/store
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
584 | 584 | | |
585 | 585 | | |
586 | 586 | | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
587 | 595 | | |
588 | | - | |
589 | | - | |
590 | | - | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
591 | 613 | | |
592 | 614 | | |
593 | 615 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1836 | 1836 | | |
1837 | 1837 | | |
1838 | 1838 | | |
1839 | | - | |
1840 | | - | |
1841 | | - | |
1842 | | - | |
1843 | | - | |
1844 | | - | |
1845 | | - | |
1846 | | - | |
1847 | | - | |
1848 | | - | |
1849 | | - | |
1850 | | - | |
| 1839 | + | |
| 1840 | + | |
| 1841 | + | |
1851 | 1842 | | |
1852 | 1843 | | |
1853 | 1844 | | |
1854 | 1845 | | |
1855 | | - | |
1856 | | - | |
1857 | | - | |
1858 | | - | |
1859 | | - | |
1860 | | - | |
1861 | | - | |
1862 | | - | |
1863 | | - | |
1864 | | - | |
1865 | 1846 | | |
1866 | 1847 | | |
1867 | 1848 | | |
| |||
1880 | 1861 | | |
1881 | 1862 | | |
1882 | 1863 | | |
1883 | | - | |
1884 | | - | |
1885 | | - | |
1886 | | - | |
1887 | | - | |
1888 | | - | |
1889 | | - | |
1890 | | - | |
1891 | | - | |
1892 | | - | |
1893 | | - | |
1894 | 1864 | | |
1895 | 1865 | | |
1896 | 1866 | | |
1897 | 1867 | | |
1898 | 1868 | | |
1899 | 1869 | | |
1900 | | - | |
1901 | | - | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
1902 | 1883 | | |
1903 | | - | |
1904 | | - | |
1905 | | - | |
1906 | 1884 | | |
1907 | 1885 | | |
1908 | 1886 | | |
1909 | 1887 | | |
1910 | 1888 | | |
1911 | 1889 | | |
1912 | | - | |
| 1890 | + | |
1913 | 1891 | | |
1914 | 1892 | | |
1915 | | - | |
1916 | 1893 | | |
1917 | 1894 | | |
1918 | 1895 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
| 57 | + | |
| 58 | + | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | | - | |
| 36 | + | |
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
| |||
70 | 69 | | |
71 | 70 | | |
72 | 71 | | |
73 | | - | |
74 | | - | |
75 | | - | |
| 72 | + | |
76 | 73 | | |
77 | 74 | | |
78 | 75 | | |
| |||
93 | 90 | | |
94 | 91 | | |
95 | 92 | | |
96 | | - | |
97 | | - | |
98 | | - | |
| 93 | + | |
99 | 94 | | |
100 | 95 | | |
101 | 96 | | |
| |||
0 commit comments