Repository navigation
Commit ecf3011
* fix(signals): an error boundary a held pass mounts over a staged error settles (#4480)
boundarySeam's fold-back (D-16, U-9: a fallback staged into the hold its
readers landed in is content-ready at that hold's commit) ran for error
boundaries too. What an error boundary still waits on after `prune` is an
error staged into the hold (D-41), not a landing: clearing its readers
redrew the output, which met the staged error again, set the error signal
and produced a new output — and the held effect that owns the boundary
re-ran on it, mounting a fresh one, forever ("Potential Infinite Loop
Detected ... last staged node: effect").
The fold-back is now a loading boundary's only. The error is an answer
staged with the frame (D-41, F-12): the held frame keeps what it showed and
the error fallback reveals with the hold (F-1, F-2).
Not optimistic-specific: any held pass (an effect re-run under a
transition's hold) that mounts createErrorBoundary over a memo whose
rejection is staged in that hold hung. The #4480 shape reaches it through
the D-34 hold of a filter change behind a pending guess.
Pins: packages/signals/tests/errored-held-mount-staged-error-4480.test.ts
(the general shape), packages/web/test/optimistic-reask-error-effect-boundary-4480.spec.tsx
(the issue's repro).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): a derived store's held rejection is staged with its frame (#4489)
handleAsync published any rejection of a node with a setter (only a
projection's derive passes one) at once, skipping D-41's staging. The
store's effect and the screen still waited (their held passes), but an
untracked read of a leaf pulled the errored derive and threw the new error
while the screen still showed the rows: a click handler on a held row
crashed (#4489, with an optimistic removal guess holding a filter change,
D-34).
A held derive's rejection now stages like a memo's (`stageError`): readers
in the hold derive from the staging and stage their own error with the
frame; a reader served the screen, an untracked read included, reads the
committed leaves (with the guesses over them, F-11) until the frame
reveals, when the error shows to the screen, the error arm and reads alike
(D-41, D-29, D-34; F-1 "what it does not say"). The change is the deletion
of the projection exception: core gets 3 B smaller.
Closes D-41's open derived-store deviation: its `it.fails` pin in
tests/error-is-an-answer.test.ts passes, now as `it`; RULES-DERIVED.md's
"Deviation today" note for it is updated.
Pin: packages/signals/tests/optimistic-held-error-untracked-read-4489.test.ts
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): a removal guess re-based over a new question shows only its answer's rows (#4482)
An older question's truth landing beneath a keyed arrangement guess is
re-based by row key (D-35, `_laneRebase`): rows from the truth, the guess's
order, the rows it removed left out. It also kept every guessed row the
truth lacked ("the guess's own landing judges them") — meant for rows the
guess added, but it kept the rows the guess had only carried over from the
truth it was written on too. After a filter switch held behind the guess
(D-34), an assign's refresh answering the new question re-based the close
guess into the open list's #1 and #4 beside the closed list's #2: rows of
two questions on one screen (F-1).
The guess's `removed` set now holds every key of the view the setter saw
that is not the guess's own row: the rows it removed (as before) and the
rows it carried over unchanged from the committed truth (the committed row
object itself). The re-base takes those from the new truth; rows the guess
added, or carried from another action's pending guess (#4336's layered
filter), stay. The screen at the assign's acceptance is the close guess
composed over the closed answer, `[#2 eve]` (the issue's second acceptable
frame). The re-base also loses its null check on the set.
Pin: packages/web/test/optimistic-removal-rebase-new-question-4482.spec.tsx
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): a derive's post-await writes no longer leak into the next setter (#4484)
The store traps notify a write-override write (a derive's continuation
after an `await`, which runs with no setter open) at once, but `touch` had
also listed its target in `pendingNotify`, and nothing took it off. The
next outermost `storeSetter` — on any store — drained the list at its exit
and notified that target with `userWrite` set: on an optimistic family the
derive's staged landing (the truth held beneath a pending guess) went
through `optHooks.writes` as the user's edit and became guesses. A guess on
the detail store thus put the list's truth over the close action's removal
guess: #3 came back while the close was out.
An outermost setter now clears the stale entries on entry (every entry
there was notified already). The guess holds until its own refresh answers
it (F-11, D-33, D-35); a guess on another store does not touch it. With the
fetch in a memo the derive writes inside its pass and never hit this.
Pin: packages/web/test/optimistic-removal-survives-other-store-guess-4484.spec.tsx
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* test(web): import the #4480 pin's createErrorBoundary from solid-js/internal
The boundary primitive is exported from `solid-js` at runtime but typed for
renderers through `solid-js/internal`; the web spec type check
(`test-types`) failed on the `solid-js` import.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* perf(signals): the #4484 setter-entry clear runs only when the list is not empty
Clearing an empty Set allocates a new table: the outermost-setter clear
cost every setter one allocation (store write floor, steady state: +4.3%
instructions under callgrind with CodSpeed's flags; CodSpeed -7.6%). The
list is empty at an outermost setter's entry but for write-override
targets, so the clear now follows a size read: +1.4% for +8 B minified.
(A flag set in touch measured +0.27% but cost +34 B.)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
---------
Co-authored-by: Claude <[email protected]>
1 parent e6c2f3b commit ecf3011
16 files changed
Lines changed: 676 additions & 28 deletions
File tree
- .changeset
- packages
- signals
- docs
- src
- core
- store
- tests
- web/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
361 | | - | |
| 361 | + | |
362 | 362 | | |
363 | 363 | | |
364 | 364 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
406 | 406 | | |
407 | 407 | | |
408 | 408 | | |
409 | | - | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
410 | 414 | | |
| 415 | + | |
411 | 416 | | |
412 | 417 | | |
413 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
563 | 563 | | |
564 | 564 | | |
565 | 565 | | |
566 | | - | |
567 | | - | |
568 | | - | |
569 | | - | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
570 | 570 | | |
571 | 571 | | |
572 | 572 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
168 | | - | |
169 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
170 | 174 | | |
171 | 175 | | |
172 | 176 | | |
173 | 177 | | |
174 | 178 | | |
| 179 | + | |
175 | 180 | | |
176 | 181 | | |
177 | 182 | | |
178 | 183 | | |
179 | 184 | | |
180 | 185 | | |
181 | 186 | | |
182 | | - | |
| 187 | + | |
183 | 188 | | |
184 | 189 | | |
185 | 190 | | |
| |||
344 | 349 | | |
345 | 350 | | |
346 | 351 | | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
352 | 361 | | |
353 | 362 | | |
354 | 363 | | |
| |||
375 | 384 | | |
376 | 385 | | |
377 | 386 | | |
| 387 | + | |
378 | 388 | | |
379 | 389 | | |
380 | 390 | | |
| |||
387 | 397 | | |
388 | 398 | | |
389 | 399 | | |
390 | | - | |
| 400 | + | |
391 | 401 | | |
392 | | - | |
393 | 402 | | |
394 | 403 | | |
395 | 404 | | |
396 | | - | |
| 405 | + | |
397 | 406 | | |
398 | 407 | | |
399 | 408 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
336 | 340 | | |
337 | 341 | | |
338 | 342 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
298 | | - | |
299 | | - | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
300 | 301 | | |
301 | 302 | | |
302 | 303 | | |
| |||
2466 | 2467 | | |
2467 | 2468 | | |
2468 | 2469 | | |
| 2470 | + | |
| 2471 | + | |
| 2472 | + | |
| 2473 | + | |
| 2474 | + | |
| 2475 | + | |
| 2476 | + | |
| 2477 | + | |
| 2478 | + | |
2469 | 2479 | | |
2470 | 2480 | | |
2471 | 2481 | | |
| |||
0 commit comments