Repository navigation
Commit ea35dd3
committed
fix(h): merge selector classes with a getter class prop instead of throwing
A component that forwards its props to a selector-class element
(props => h("button.btn", props)) receives a reactive class as a getter.
Merging it with the static classes spread the accessor descriptor and
added a value, so Object.defineProperties threw "Invalid property
descriptor. Cannot both specify accessors and a value or writable
attribute". A hand-written get class() on h("div.card", ...) threw the
same way.
Drop get/set from the descriptor and read the getter through the props
object, so the existing function path turns the merged class into a
getter that stays reactive.1 parent 4e1a83a commit ea35dd3
3 files changed
Lines changed: 39 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
163 | 166 | | |
164 | | - | |
| 167 | + | |
165 | 168 | | |
166 | 169 | | |
167 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
281 | 310 | | |
0 commit comments