|
| 1 | +/** |
| 2 | + * #4305: a keyed projection over an async memo follows every landing. The |
| 3 | + * memo going pending marks the derive without re-running it (#4271), and the |
| 4 | + * family wakes the leaves' readers pending on the derive — the source the |
| 5 | + * landing's settle walk retires. A per-row memo reading a leaf whose value the |
| 6 | + * landing leaves unchanged does not re-run, so a wake parked on the upstream |
| 7 | + * memo instead held it (and the render effect over it) after the first landing. |
| 8 | + * "rederive": the derive re-runs while the memo is pending (another source of |
| 9 | + * it changes), its pass throwing the memo's NotReady — the same wake. |
| 10 | + */ |
| 11 | +import { describe, expect, it } from "vitest"; |
| 12 | +import { |
| 13 | + createMemo, |
| 14 | + createProjection, |
| 15 | + createRenderEffect, |
| 16 | + createRoot, |
| 17 | + createSignal, |
| 18 | + flush, |
| 19 | + mapArray |
| 20 | +} from "../src/index.js"; |
| 21 | + |
| 22 | +type Row = { id: number; name: string }; |
| 23 | + |
| 24 | +const tick = async () => { |
| 25 | + for (let i = 0; i < 3; i++) { |
| 26 | + await new Promise(r => setTimeout(r, 0)); |
| 27 | + flush(); |
| 28 | + } |
| 29 | +}; |
| 30 | + |
| 31 | +for (const mode of ["row-memo", "direct", "rederive"] as const) { |
| 32 | + describe(`#4305 (${mode})`, () => { |
| 33 | + it("a keyed projection over an async memo follows every landing", async () => { |
| 34 | + const [q, setQ] = createSignal(""); |
| 35 | + const [other, setOther] = createSignal(0); |
| 36 | + const res: Record<string, (rows: Row[]) => void> = {}; |
| 37 | + let screen = ""; |
| 38 | + const dispose = createRoot(d => { |
| 39 | + const src = createMemo(() => |
| 40 | + q() === "" ? ([] as Row[]) : new Promise<Row[]>(r => (res[q()] = r)) |
| 41 | + ); |
| 42 | + const rows = createProjection( |
| 43 | + () => { |
| 44 | + other(); |
| 45 | + return src(); |
| 46 | + }, |
| 47 | + [] as Row[], |
| 48 | + { key: "id" } |
| 49 | + ); |
| 50 | + if (mode === "direct") |
| 51 | + createRenderEffect( |
| 52 | + () => rows.map(r => r.name).join(","), |
| 53 | + v => { |
| 54 | + screen = v; |
| 55 | + } |
| 56 | + ); |
| 57 | + else { |
| 58 | + const views = mapArray( |
| 59 | + () => rows, |
| 60 | + row => { |
| 61 | + const name = createMemo(() => row.name); |
| 62 | + return () => name(); |
| 63 | + } |
| 64 | + ); |
| 65 | + createRenderEffect( |
| 66 | + () => |
| 67 | + views() |
| 68 | + .map(f => f()) |
| 69 | + .join(","), |
| 70 | + v => { |
| 71 | + screen = v; |
| 72 | + } |
| 73 | + ); |
| 74 | + } |
| 75 | + return d; |
| 76 | + }); |
| 77 | + flush(); |
| 78 | + await tick(); |
| 79 | + expect(screen).toBe(""); |
| 80 | + |
| 81 | + setQ("ap"); |
| 82 | + flush(); |
| 83 | + await tick(); |
| 84 | + res.ap([ |
| 85 | + { id: 1, name: "apple" }, |
| 86 | + { id: 2, name: "apricot" } |
| 87 | + ]); |
| 88 | + await tick(); |
| 89 | + expect(screen).toBe("apple,apricot"); |
| 90 | + |
| 91 | + // Row 1 survives with its name unchanged: its memo does not re-run. |
| 92 | + setQ("app"); |
| 93 | + flush(); |
| 94 | + await tick(); |
| 95 | + if (mode === "rederive") { |
| 96 | + setOther(1); |
| 97 | + flush(); |
| 98 | + await tick(); |
| 99 | + } |
| 100 | + expect(screen).toBe("apple,apricot"); |
| 101 | + res.app([ |
| 102 | + { id: 1, name: "apple" }, |
| 103 | + { id: 3, name: "applesauce" }, |
| 104 | + { id: 4, name: "apple pie" } |
| 105 | + ]); |
| 106 | + await tick(); |
| 107 | + expect(screen).toBe("apple,applesauce,apple pie"); |
| 108 | + |
| 109 | + // Row 1 survives with a changed name; row 4 survives unchanged. |
| 110 | + setQ("appl"); |
| 111 | + flush(); |
| 112 | + await tick(); |
| 113 | + expect(screen).toBe("apple,applesauce,apple pie"); |
| 114 | + res.appl([ |
| 115 | + { id: 1, name: "apple tart" }, |
| 116 | + { id: 4, name: "apple pie" } |
| 117 | + ]); |
| 118 | + await tick(); |
| 119 | + expect(screen).toBe("apple tart,apple pie"); |
| 120 | + |
| 121 | + dispose(); |
| 122 | + }); |
| 123 | + }); |
| 124 | +} |
0 commit comments