You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e16371f
Browse filesBrowse the repository at this point in the historyBrowse files
Effect creation: introduce createEffectNode with the full hidden-class
shape baked into one literal, share notifyEffectStatus across instances
instead of allocating a closure per effect, register the disposal cleanup
lazily on first cleanup-fn return, and hoist Root.dispose into a shared
disposeRootSelf. Adds a fast path in storeTraps.get for tracked reads of
absent plain-object properties so subscribers do not pay the full
override/optimistic resolution chain.
CONFIG_SYNC opt-in: new sync? option on MemoOptions/EffectOptions skips
the async-shape probe in recompute for nodes that provably never return
Promise/AsyncIterable. Compiler-emitted _$effect/_$memo (via @solidjs/web
wrappers) opt in by default. Dev keeps the probe and surfaces
SYNC_NODE_RECEIVED_ASYNC when a sync: true node returns an awaitable;
production silently stores the value as-is, by contract.
flush(fn) drains at every nesting level instead of only the outermost,
so nested flush(fn) calls each honor their own contract. Updates the
js-reactivity-benchmark fixture and adds coverage in flush.test.ts /
diagnostics.test.ts.
Engineering standards: document the changeset-target convention so the
header lists the package(s) that actually changed, by directory, rather
than always defaulting to solid-js.
Co-authored-by: Cursor <[email protected]>
Reduce effect creation overhead by sharing status notification logic, registering effect cleanups lazily, and avoiding generic store proxy work for tracked reads of absent plain-object properties.
Performance: add `CONFIG_SYNC` opt-in for sync-only computeds/effects. New `sync?: boolean` option on `MemoOptions`/`EffectOptions` skips the async-shape probe in `recompute` for nodes that provably never return Promise/AsyncIterable. Compiler-emitted `_$effect` and `_$memo` (via `@solidjs/web`'s `effect`/`memo` wrappers) opt in by default — `01_run1k` mean −0.62 ms and `08_create1k-after1k_x2` mean −0.80 ms in `js-framework-benchmark`. User-authored `createMemo`/`createEffect`/`createRenderEffect` keep full async-aware behavior unless they explicitly pass `sync: true`. Returning a Promise from a `sync: true` node throws `SYNC_NODE_RECEIVED_ASYNC` in dev (production silently stores the unawaited value, by contract).
7
+
8
+
Correctness: `flush(fn)` now drains at every nesting level instead of only the outermost. Nested `flush(fn)` calls each honor their own contract — writes inside an inner `flush(fn)` propagate before it returns, rather than being held until the outer `flush(fn)` exits. Microtask scheduling and arg-less `flush()` are unchanged. Code that depended on the old hold-until-outermost behavior should switch to a harness-layer depth counter (see `js-reactivity-benchmark`'s `r3` / `r3-solid-target` adapters for the pattern).
Copy file name to clipboardExpand all lines: .cursor/rules/engineering-standards.mdc
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -36,14 +36,14 @@ Since `pnpm changeset` is interactive and cannot be used from the agent, create
36
36
```markdown
37
37
// .changeset/<descriptive-name>.md
38
38
---
39
-
"solid-js": patch
39
+
"@solidjs/signals": patch
40
40
---
41
41
42
42
Short summary of the change
43
43
```
44
44
45
45
- Use `patch` for bug fixes, `minor` for features, `major` for breaking changes.
46
-
- All packages in the `fixed` group version together — only list the primary package affected (usually `solid-js`).
46
+
- List the package(s) that actually changed, by directory. Source under `packages/solid/src/` → `solid-js`; `packages/solid-signals/src/` → `@solidjs/signals`; `packages/solid-web/src/` → `@solidjs/web`; etc. If a single change touches multiple package sources, list each one. (All packages in the `fixed` group still version together; the changeset header is documenting *what* changed, not *what bumps*.)
47
47
- If a commit only touches examples, tests, or tooling config (not source under `packages/`), no changeset is needed.
48
48
- The changeset file name should be descriptive (e.g., `fix-ssr-async-error-handling.md`), not random words.
0 commit comments