You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit de1c8b5
Browse filesBrowse the repository at this point in the historyBrowse files
revert(signals,solid): drop the complete-seed requirement on derived stores (#3258)
Derived createStore/createProjection/createOptimisticStore accept Partial<T>
seeds again. #3258 merged without maintainer review; on review the ruling is
that the requirement's ergonomic cost exceeds what it fixes: any async object
store reconciling on a non-'id' key needs the options slot and therefore the
seed slot, and there the seed is pure ceremony — reads pend until the first
resolution, so a fabricated complete T is never observable (verified: an
uninitialized derived read throws NotReadyError; the seed never leaks). The
type-honesty gain is real only for sync draft-reading callbacks and is better
served by the #3194 seedless-callback direction. #3260's overload alignment
(slot order, shallow in options, Refreshable derived returns, NoFn on plain
roots) stays. Since #3258 never shipped, its pending changeset is dropped;
the API is unchanged from 2.0.0-rc.6.
Co-authored-by: Cursor <[email protected]>
Revert the complete-seed requirement on derived store forms (#3258). Derived `createStore`, `createProjection`, and derived `createOptimisticStore` accept `Partial<T>` seeds again, on maintainer review: requiring a full `T` forces callers to fabricate a throwaway complete object in the common async case — any object store reconciling on a non-`id` key needs the options slot, hence the seed slot — while the seed is never observable there (reads pend until the first resolution). The type-honesty concern it addressed is real only for sync draft-reading callbacks and is better served by the seedless-callback direction discussed in #3194. Since #3258 never shipped in a release, its pending changeset is dropped rather than superseded; the API is unchanged from 2.0.0-rc.6. The #3260 overload alignment (slot order, `shallow` in options, `Refreshable` derived returns) is unaffected.
0 commit comments