|
| 1 | +// Pins for what #4393 (R5, D-22) fixed beyond #4365, and one row it leaves |
| 2 | +// for the reader-seat carve. |
| 3 | +// |
| 4 | +// - #4402: a pass that reads `latest(s)` before `s()` computes once per |
| 5 | +// plain write, as `[s(), latest(s)]` does (D-22: one pass; it re-derives |
| 6 | +// only if the flush parks). |
| 7 | +// - #4398: `[isPending(m1), m1()]` in one effect, split across two, or |
| 8 | +// `m1()` alone show the same values when the write changes during the hold |
| 9 | +// (D-26, F-6: a grouped read holds as a lone read; #4284). |
| 10 | +// - #4399 (it.fails, carve row): two actions, each holding a verdict |
| 11 | +// memo's write, ask `m1:15` twice: once in A's verdict lane, once in B's |
| 12 | +// transaction over the same inputs (F-9). |
| 13 | +import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; |
| 14 | +import { |
| 15 | + action, |
| 16 | + createEffect, |
| 17 | + createLoadingBoundary, |
| 18 | + createMemo, |
| 19 | + createRenderEffect, |
| 20 | + createRoot, |
| 21 | + createSignal, |
| 22 | + flush, |
| 23 | + isPending, |
| 24 | + latest |
| 25 | +} from "../src/index.js"; |
| 26 | + |
| 27 | +// Fake timers: the flights' order is the script's, not the runner's speed. |
| 28 | +const sleep = (ms: number) => new Promise(r => setTimeout(r, ms)); |
| 29 | +const wait = (ms: number) => vi.advanceTimersByTimeAsync(ms); |
| 30 | +async function settle(n = 4) { |
| 31 | + for (let i = 0; i < n; i++) { |
| 32 | + await wait(15); |
| 33 | + flush(); |
| 34 | + } |
| 35 | +} |
| 36 | + |
| 37 | +describe("#4402: latest(s) before s() computes once on a plain write", () => { |
| 38 | + for (const order of ["latest first", "plain first"] as const) |
| 39 | + for (const reader of ["render effect", "memo", "user effect"] as const) |
| 40 | + it(`${order}, ${reader}`, () => { |
| 41 | + const [s, set] = createSignal(0); |
| 42 | + let runs = 0; |
| 43 | + const f = () => (runs++, order === "latest first" ? [latest(s), s()] : [s(), latest(s)]); |
| 44 | + const dispose = createRoot(dispose => { |
| 45 | + if (reader === "render effect") createRenderEffect(f, () => {}); |
| 46 | + else if (reader === "user effect") createEffect(f, () => {}); |
| 47 | + else createRenderEffect(createMemo(f), () => {}); |
| 48 | + return dispose; |
| 49 | + }); |
| 50 | + flush(); |
| 51 | + runs = 0; |
| 52 | + set(1); |
| 53 | + flush(); |
| 54 | + expect(runs).toBe(1); |
| 55 | + dispose(); |
| 56 | + }); |
| 57 | +}); |
| 58 | + |
| 59 | +type Reader = "pair" | "split" | "value"; |
| 60 | + |
| 61 | +beforeEach(() => void vi.useFakeTimers()); |
| 62 | +afterEach(() => void vi.useRealTimers()); |
| 63 | + |
| 64 | +async function run(reader: Reader, script: "change" | "two-actions") { |
| 65 | + const [s, setS] = createSignal(1); |
| 66 | + const [t, setT] = createSignal(0); |
| 67 | + const asks: string[] = []; |
| 68 | + const out: string[] = []; |
| 69 | + const ask = (n: string, v: number) => { |
| 70 | + asks.push(`${n}:${v}`); |
| 71 | + return sleep(10).then(() => v); |
| 72 | + }; |
| 73 | + const show = (v: string) => void out.push(v); |
| 74 | + const dispose = createRoot(dispose => { |
| 75 | + const m0 = createMemo(() => ask("m0", 1 + latest(s) + s())); |
| 76 | + const m0b = createMemo(() => ask("m0b", 10 * (latest(t) + t()))); |
| 77 | + const m1 = createMemo(() => ask("m1", 1 + m0() + (script === "two-actions" ? m0b() : 0))); |
| 78 | + const h = createMemo(() => (s() === 1 ? 1 : sleep(80).then(() => 1))); |
| 79 | + createLoadingBoundary( |
| 80 | + () => { |
| 81 | + const pre = () => (script === "two-actions" ? h() : 0); |
| 82 | + if (reader === "pair") createRenderEffect(() => (pre(), `${isPending(m1)},v${m1()}`), show); |
| 83 | + else if (reader === "split") { |
| 84 | + createRenderEffect(() => (pre(), `p${isPending(m1)}`), show); |
| 85 | + createRenderEffect(() => (pre(), `v${m1()}`), show); |
| 86 | + } else createRenderEffect(() => (pre(), `v${m1()}`), show); |
| 87 | + return null; |
| 88 | + }, |
| 89 | + () => "L" |
| 90 | + ); |
| 91 | + return dispose; |
| 92 | + }); |
| 93 | + flush(); |
| 94 | + await settle(); |
| 95 | + asks.length = 0; |
| 96 | + out.length = 0; |
| 97 | + if (script === "change") { |
| 98 | + setS(2); |
| 99 | + await wait(25); |
| 100 | + flush(); |
| 101 | + setS(4); |
| 102 | + } else { |
| 103 | + action(function* () { |
| 104 | + setS(2); |
| 105 | + yield sleep(30); |
| 106 | + })(); |
| 107 | + await wait(5); |
| 108 | + action(function* () { |
| 109 | + setT(1); |
| 110 | + yield sleep(50); |
| 111 | + })(); |
| 112 | + flush(); |
| 113 | + } |
| 114 | + await settle(); |
| 115 | + await settle(); |
| 116 | + await settle(); |
| 117 | + dispose(); |
| 118 | + const values = out.map(v => v.match(/v(\d+)/)?.[1]).filter(v => v !== undefined); |
| 119 | + return { asks, values: values.filter((v, i) => v !== values[i - 1]) }; |
| 120 | +} |
| 121 | + |
| 122 | +describe("#4398: grouping isPending(m1) with m1() shows the same values", () => { |
| 123 | + it.each(["pair", "split", "value"] as const)("a change during the hold (%s)", async reader => { |
| 124 | + // The screen before the write (`4`) shows again only in the pair, where |
| 125 | + // `isPending` turns true beside it. |
| 126 | + const { values } = await run(reader, "change"); |
| 127 | + expect(values.filter(v => v !== "4")).toEqual(["5", "8", "10"]); |
| 128 | + }); |
| 129 | +}); |
| 130 | + |
| 131 | +describe("#4399: two actions, each holding a verdict memo's write", () => { |
| 132 | + // F-9: a re-ask of the same question is no new question. A row for the |
| 133 | + // reader-seat carve: telling B's pass apart from A's lane pass over the |
| 134 | + // same inputs needs a per-pass check. |
| 135 | + const once = async (reader: Reader) => { |
| 136 | + const { asks, values } = await run(reader, "two-actions"); |
| 137 | + expect(new Set(asks).size, asks.join(" ")).toBe(asks.length); |
| 138 | + expect(values.at(-1)).toBe("26"); |
| 139 | + }; |
| 140 | + it("each question asked once (pair)", () => once("pair")); |
| 141 | + it.fails.each(["split", "value"] as const)("each question asked once (%s)", once); |
| 142 | +}); |
0 commit comments