Repository navigation
Commit ca82433
* ci: track tree-shaken scenario sizes per PR with size-limit (#2883)
Five import-cost scenarios (signals floor / +createStore / +isPending,
latest; the render+signal simple-app floor; a representative CSR app)
with ~5% headroom limits as the tree-shaking regression gate — a
re-coupled feature module costs hundreds of bytes against that headroom.
The simple-app ceiling is pinned at 10 KB (brotli) deliberately. The
size-limit action comments base-vs-head deltas on every PR; the
retained-module-graph test in solid-signals stays the precise
which-module diagnostic.
Co-Authored-By: Claude Fable 5 <[email protected]>
* ci: split size workflow into a self-contained gate and best-effort delta comment
The size-limit action compares against the base branch, which fails on
any PR whose base lacks the size-limit setup (including this bootstrap
PR) with 'Unexpected end of JSON input'. The hard gate is now its own
job — install, build, pnpm size on the head only — and the base-vs-head
comment job is continue-on-error, so it informs when it can and never
blocks.
Co-Authored-By: Claude Fable 5 <[email protected]>
* ci(size): resolve fixtures via esbuild aliases, not root workspace deps
Adding solid-js/@solidjs/* as root devDeps re-keyed pnpm's peer graph
(vitest and vite-plugin-solid instances gained new peer contexts),
relocating the benchmark harness's physical dependencies — which CodSpeed
reports as instruction-count regressions despite zero code changes.
Aliases in .size-limit.js point bare specifiers at the built browser-prod
artifacts instead; the lockfile now only adds size-limit's own isolated
tree. Same measured numbers on every scenario.
Co-Authored-By: Claude Fable 5 <[email protected]>
* ci(size): isolate size tooling in a standalone size/ package
Any change to the workspace dependency graph re-keys pnpm peer instances
— removing the workspace devDeps still moved @codspeed/vitest-plugin and
vite instance keys (vite's optional terser peer context) — and relocating
the benchmark harness shows up as phantom CodSpeed regressions. size/ is
now a plain npm package outside the pnpm workspace with its own lockfile;
the root package.json and pnpm-lock.yaml are byte-identical to next.
Fixtures resolve bare specifiers via esbuild aliases to the built
browser-prod artifacts. Same measured numbers on every scenario.
Co-Authored-By: Claude Fable 5 <[email protected]>
* ci(size): relocate to scripts/size
Same isolated-from-the-workspace setup, less top-level clutter; README
documents why it must stay outside the pnpm workspace graph.
Co-Authored-By: Claude Fable 5 <[email protected]>
---------
Co-authored-by: Claude Fable 5 <[email protected]>
1 parent d0b9c91 commit ca82433
9 files changed
Lines changed: 839 additions & 0 deletions
File tree
- .github/workflows
- scripts/size
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments