You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c07a044
Browse filesBrowse the repository at this point in the historyBrowse files
committed
build(signals): development CJS build so server.dev.cjs gets a live DEV
The `require` branch of @solidjs/signals' exports had only the prod
dist/node.cjs (__DEV__ false). A CJS host that resolved solid-js's
dist/server.dev.cjs under `development` therefore required a prod signals
and got DEV === undefined from a dev artifact — a lie that goes unnoticed
until P1 makes the server emit into DEV.diagnostics.
- dist/node.dev.cjs: flat, unmangled twin of dist/dev.js; `development`
condition on the `require` branch selects it
- signals dist test pins DEV per CJS artifact and equal export surface
- web resolution test walks the CJS hops (@solidjs/web -> solid-js ->
@solidjs/signals) under `development` and pins all three flipping
together
- turbo: solid-js#test now depends on solid-js#build — it had no
dist-based tests until this branch, so it was the only package whose
test task didn't wait for its own build
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Add a development CJS build, `dist/node.dev.cjs`, selected by the `development` condition on the `require` branch of `exports`. Previously `require` always resolved to the production `dist/node.cjs` (`__DEV__` false), so a CJS host that resolved `solid-js`'s dev server artifact would get `DEV === undefined` from its `@solidjs/signals` dependency — a dev server runtime whose diagnostics channel was silently absent. Dev CJS is the unmangled twin of `dist/dev.js`; the production CJS is unchanged.
0 commit comments