Repository navigation
Commit be5a6a7
committed
fix(attribution): count GRAPH_GROWTH after a held navigation's landing commits
A navigation that settles in a transaction's landing was counted from the
transitionSettled hook, before land() commits and disposes the frame parked
for the page left. The walk still reached those computations through the
sources both pages read, so arriving at a small route from ever bigger pages
reported an ownerless-effect leak. Defer the graph walk for landed
navigations to flushEnd; the navigation record still settles in the landing.
Fixes #3989
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015Q7JD9PktsxtBJJbWmtuwr1 parent 2322d64 commit be5a6a7
4 files changed
Lines changed: 99 additions & 6 deletions
File tree
- .changeset
- packages
- signals
- src/core
- tests
- solid/skills/reactivity-diagnostics
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3480 | 3480 | | |
3481 | 3481 | | |
3482 | 3482 | | |
| 3483 | + | |
| 3484 | + | |
| 3485 | + | |
| 3486 | + | |
| 3487 | + | |
| 3488 | + | |
| 3489 | + | |
| 3490 | + | |
3483 | 3491 | | |
3484 | 3492 | | |
3485 | 3493 | | |
| |||
3597 | 3605 | | |
3598 | 3606 | | |
3599 | 3607 | | |
3600 | | - | |
| 3608 | + | |
3601 | 3609 | | |
3602 | 3610 | | |
3603 | 3611 | | |
| |||
3775 | 3783 | | |
3776 | 3784 | | |
3777 | 3785 | | |
| 3786 | + | |
| 3787 | + | |
| 3788 | + | |
3778 | 3789 | | |
3779 | 3790 | | |
3780 | 3791 | | |
| |||
3783 | 3794 | | |
3784 | 3795 | | |
3785 | 3796 | | |
3786 | | - | |
| 3797 | + | |
| 3798 | + | |
3787 | 3799 | | |
3788 | 3800 | | |
3789 | 3801 | | |
| |||
3797 | 3809 | | |
3798 | 3810 | | |
3799 | 3811 | | |
3800 | | - | |
| 3812 | + | |
| 3813 | + | |
3801 | 3814 | | |
3802 | 3815 | | |
3803 | 3816 | | |
| |||
4427 | 4440 | | |
4428 | 4441 | | |
4429 | 4442 | | |
| 4443 | + | |
4430 | 4444 | | |
4431 | 4445 | | |
4432 | 4446 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
317 | 318 | | |
318 | 319 | | |
319 | 320 | | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
320 | 394 | | |
321 | 395 | | |
322 | 396 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
295 | | - | |
296 | | - | |
297 | | - | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
| |||
0 commit comments