@@ -726,6 +726,114 @@ describe("async compute", () => {
726726 } ) ;
727727 } ) ;
728728
729+ it ( "should let a manual setSignal write to a memo win over a queued recompute (#2692)" , ( ) => {
730+ const [ original , setOriginal , derived , setDerived ] = createRoot ( ( ) => {
731+ const [ o , setO ] = createSignal ( 0 ) ;
732+ const [ d , setD ] = createSignal ( o ) ;
733+ return [ o , setO , d , setD ] as const ;
734+ } ) ;
735+ expect ( derived ( ) ) . toBe ( 0 ) ;
736+ setOriginal ( 1 ) ;
737+ setDerived ( 2 ) ;
738+ flush ( ) ;
739+ expect ( original ( ) ) . toBe ( 1 ) ;
740+ expect ( derived ( ) ) . toBe ( 2 ) ;
741+ // Subsequent change to upstream still recomputes the memo
742+ setOriginal ( 3 ) ;
743+ flush ( ) ;
744+ expect ( derived ( ) ) . toBe ( 3 ) ;
745+ } ) ;
746+
747+ it ( "should let a manual setSignal write win even when an intermediate memo re-marks it (#2692)" , ( ) => {
748+ let observed : number | undefined ;
749+ const [ setA , setC ] = createRoot ( ( ) => {
750+ const [ a , sA ] = createSignal ( 0 ) ;
751+ const b = createMemo ( ( ) => a ( ) * 10 ) ;
752+ const [ c , sC ] = createSignal ( b ) ;
753+ createRenderEffect ( c , v => {
754+ observed = v ;
755+ } ) ;
756+ return [ sA , sC ] as const ;
757+ } ) ;
758+ flush ( ) ;
759+ expect ( observed ) . toBe ( 0 ) ;
760+ setA ( 1 ) ;
761+ setC ( 99 ) ;
762+ flush ( ) ;
763+ expect ( observed ) . toBe ( 99 ) ;
764+ setA ( 2 ) ;
765+ flush ( ) ;
766+ expect ( observed ) . toBe ( 20 ) ;
767+ } ) ;
768+
769+ it ( "write trumps recompute regardless of order within a tick (#2692)" , ( ) => {
770+ const [ setOriginal , setDerived , derived ] = createRoot ( ( ) => {
771+ const [ original , setO ] = createSignal ( 0 ) ;
772+ const [ d , setD ] = createSignal ( original ) ;
773+ return [ setO , setD , d ] as const ;
774+ } ) ;
775+ setDerived ( 2 ) ;
776+ setOriginal ( 1 ) ;
777+ flush ( ) ;
778+ expect ( derived ( ) ) . toBe ( 2 ) ;
779+ } ) ;
780+
781+ it ( "latest manual write wins on a memo within a tick (#2692)" , ( ) => {
782+ const [ setOriginal , setDerived , derived ] = createRoot ( ( ) => {
783+ const [ original , setO ] = createSignal ( 0 ) ;
784+ const [ d , setD ] = createSignal ( original ) ;
785+ return [ setO , setD , d ] as const ;
786+ } ) ;
787+ setOriginal ( 1 ) ;
788+ setDerived ( 2 ) ;
789+ setDerived ( 3 ) ;
790+ flush ( ) ;
791+ expect ( derived ( ) ) . toBe ( 3 ) ;
792+ } ) ;
793+
794+ it ( "same-value manual write still trumps recompute within a tick (#2692)" , ( ) => {
795+ const [ setOriginal , setDerived , derived ] = createRoot ( ( ) => {
796+ const [ original , setO ] = createSignal ( 0 ) ;
797+ const [ d , setD ] = createSignal ( original ) ;
798+ return [ setO , setD , d ] as const ;
799+ } ) ;
800+ setOriginal ( 1 ) ;
801+ setDerived ( 0 ) ;
802+ flush ( ) ;
803+ expect ( derived ( ) ) . toBe ( 0 ) ;
804+ } ) ;
805+
806+ it ( "refresh() forces a recompute even after a manual memo write in the same tick (#2692)" , ( ) => {
807+ const [ setOriginal , setDerived , derived ] = createRoot ( ( ) => {
808+ const [ original , setO ] = createSignal ( 0 ) ;
809+ const [ d , setD ] = createSignal ( original ) ;
810+ return [ setO , setD , d ] as const ;
811+ } ) ;
812+ setOriginal ( 1 ) ;
813+ setDerived ( 2 ) ;
814+ refresh ( derived ) ;
815+ flush ( ) ;
816+ expect ( derived ( ) ) . toBe ( 1 ) ;
817+ } ) ;
818+
819+ it ( "should propagate manual setSignal write to subscribers when upstream also changed (#2692)" , ( ) => {
820+ let observed : number | undefined ;
821+ const [ setOriginal , setDerived ] = createRoot ( ( ) => {
822+ const [ original , setO ] = createSignal ( 0 ) ;
823+ const [ derived , setD ] = createSignal ( original ) ;
824+ createRenderEffect ( derived , v => {
825+ observed = v ;
826+ } ) ;
827+ return [ setO , setD ] as const ;
828+ } ) ;
829+ flush ( ) ;
830+ expect ( observed ) . toBe ( 0 ) ;
831+ setOriginal ( 1 ) ;
832+ setDerived ( 2 ) ;
833+ flush ( ) ;
834+ expect ( observed ) . toBe ( 2 ) ;
835+ } ) ;
836+
729837 it ( "should allow opting into chained refresh via isRefreshing()" , ( ) => {
730838 let depRuns = 0 ;
731839 let targetRuns = 0 ;
0 commit comments