Repository navigation
Commit b0bad02
fix(signals): two crash-class bugs from the semantic fuzzer — a lane node in a held frame stays the lane's; a verdict reader revealing an orphan flight holds it (#3798)
* fix(signals): a lane's node inside a held frame stays the lane's (fuzzer F7a/F7b)
`holdFrame` holds a parked pass's frame with the transaction (ruling A).
It re-listed a lane's node found there — a verdict reader created in
the frame, broken out into the holder's verdict lane (display-ahead,
L2 rule 6), or a derivation of a guess — on the frame's transaction,
still carrying its lane value (CONFIG_OVERRIDE). At the landing
`dissolveLane` no longer found the node (its `_transaction` was the
transaction's) and `land` nulled the transaction: a lane node with no
lane, and the landing's re-derivation tripped over it (`laneRead` →
`txOf(null)` → TypeError, REACTIVITY_HALTED).
The shapes: a `Loading` whose content reads `latest(x)`, unmounted and
remounted while `x` is held by an action (F7a); a memo of
`isPending(() => x())` mounted in the tick of the write it probes, its
mount toggled off and on while the write is held (F7b). The remounting
gate's write joins the hold (A34 (1)), so its new frame is held with it
— and the verdict-lane nodes inside it were taken along.
`holdFrame` now skips a child listed on a lane, as the seam's own hold
loop already does for this flush's stagings: lane work never makes its
node transaction work (A15, #3698), and a lane pass's frame is the
lane's, revealed and retired at its seam. The lane's end (`dissolveLane`
at the parent's landing) commits the node as before. Every other
`holdNode` site (the seam loop, the store's three) already excluded
lane work; this was the one that did not.
F7a and F7b flip from `it.fails` to `it`. No other pin moved.
Co-authored-by: Claude via Cursor <[email protected]>
* fix(signals): a verdict reader revealing a flight nobody holds registers it with the frame (fuzzer F12)
A verdict reader (`latest`/`isPending` in its pass) that plainly reads a
pending node is served the committed value and `observeFlight`s it: the
frame holds, the reader is the holder's verdict lane's, and it re-derives
at the landing (REACTIVE_FRAME_READ — a blocker of the hold through the
flight's subscribers, `blockedBy`). That hold is on the flight's node: a
reader served committed never goes pending, so the transaction waits only
through the node it holds. A flight that went pending this flush is queued
for the seam to hold; one in the air from before and held by nobody was
not — the transaction opened with no entry, landed at its own seam, and
its `_reruns` re-derived the reader into the same observation, every
flush ("Potential Infinite Loop Detected").
The fuzzer's shape (F12): an action whose body ends with `setSource(1)`,
`setShow(true)` adopted in the action's tick (O1), a reader of
`[latest(source), node()]` over an async memo of `latest(source)`. At the
body's end the memo re-asks as the action's verdict lane's work (the
proposal) while the reader, a stale reader of the held `show`, shows
"hidden"; nothing displays the flight, the action lands (A29: a flight
nobody renders holds nothing), `dissolveLane` commits the memo beneath
its flight, and the landing's rerun reveals the orphan flight to the
verdict reader. Reduced: any memo re-asked unobserved (its inputs
commit, #3305) then revealed to a `latest()` reader did the same.
`observeFlight` now queues the flight's node for the seam when nobody
holds it, as if it had gone pending here (A15 first observer, #3458:
"the observation registers it, and the transaction waits on the flight
it now shows a reader of"); the seam applies its own hold rules (a
loading source is nobody's frame, A34 (2), `holdFrame`). The landing
then resumes that transaction through `setSignal`'s join and the reader
re-derives once. The display follows the existing rules: a reveal that
read a staging stays the frame's and waits with the flight (rule 3,
A15 reveal corollary — the reduced pin asserts `"hidden"` → `[1,1]`); a
verdict reader with nothing staged shows the screen ahead (rule 6).
F12 flips from `it.fails` to `it`; a reduced pin without the action or
lane is added beside it. No other pin moved.
Co-authored-by: Claude via Cursor <[email protected]>
* chore(size): raise three caps for the fuzzer F7/F12 fixes (Size-Exception)
Raises only the caps the two fixes push over, each set to measured + 10 B
rounded up to 0.01 KB, with dated ledger notes in scenarios.js:
- signals: + isPending/latest 9.45 -> 9.47 KB (9,456 B; was 6 B over)
- page: base server components 44.78 -> 44.84 KB (44,829 B; was 49 B over)
- page: live server components 48.45 -> 48.47 KB (48,454 B; was 4 B over)
Attributable delta is +33 B minified in signals (holdFrame lane gate +16,
observeFlight first-observer hold +17); the brotli deltas are layout over
the shifted stream (page base moves +67 B br on +16 B minified). All other
caps hold; no cap is loosened beyond measured + 10 B.
Size-Exception: fuzzer F7/F12 crash-class fixes — `+ isPending/latest` 9.45 -> 9.47 KB (9,456 B), `page: base` 44.78 -> 44.84 KB (44,829 B), `page: live` 48.45 -> 48.47 KB (48,454 B); +33 B minified in signals, brotli layout. Accepted by the maintainer (2026-10-05).
Co-authored-by: Claude via Cursor <[email protected]>
---------
Co-authored-by: Claude via Cursor <[email protected]>1 parent 6f77b1b commit b0bad02
9 files changed
Lines changed: 929 additions & 21 deletions
File tree
- .changeset
- packages/signals
- docs
- src/core
- tests
- scripts/size
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1684 | 1684 | | |
1685 | 1685 | | |
1686 | 1686 | | |
1687 | | - | |
| 1687 | + | |
1688 | 1688 | | |
1689 | 1689 | | |
1690 | 1690 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
397 | | - | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
398 | 407 | | |
399 | 408 | | |
| 409 | + | |
400 | 410 | | |
401 | 411 | | |
402 | 412 | | |
| |||
619 | 629 | | |
620 | 630 | | |
621 | 631 | | |
622 | | - | |
| 632 | + | |
623 | 633 | | |
624 | 634 | | |
625 | 635 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| |||
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
88 | | - | |
89 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
90 | 101 | | |
91 | 102 | | |
| 103 | + | |
92 | 104 | | |
93 | 105 | | |
94 | 106 | | |
| |||
0 commit comments