Repository navigation
Commit b07fed5
fix(signals): five rule-decided fixes from the semantic fuzzer (F3, F4, F9, F10/F11, F13) (#3801)
* test(signals): pin F13 — born-held latest() reader loses the action's final write
Brings the F13 pin from fuzz/semantic-fuzzer-l2 (f3d6342) onto next,
beside #3798's flipped F7a/F7b/F12 pins: a `latest(source)` render
effect whose mount is withdrawn in the action's tick and restored in the
next is born held with its creation value; the body-end write re-runs it
in the verdict lane, and the landing then applies the stale born-held
staging over the lane's run. Pinned as `it.fails` (A29 creation-time
form, A28). No engine changes.
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix(signals): a memo an isPending probe pulls computes outside the probe's window (fuzzer F10, F11)
`verdictValue` links and pulls like a plain read, but it pulled with the
window's dispatch still installed: `pullComputed(m)` → `recompute(m)` →
`m`'s own reads went through `verdictValue` under the probe's posture.
For a source staged this flush and not held, the unheld-staged arm
answers the probe with the committed value — right for the probe, wrong
for `m`, whose result is cached for every reader. So `m` cached the
committed input and never got the flushed one (F10: a gated `isPending`
reader revealed beside a write to the probed memo's source left the
memo's plain reader on the old value for good), and a pulled memo over
an uninitialized staged input read `undefined` instead of suspending
(F11).
A31: "a memo computes under its own lane posture, never its puller's";
A28: a write is visible at flush to every channel; A7/A19 exc. 1: an
uninitialized input suspends. The pull now drops the dispatch for the
nested pass and reinstalls it after, so the probe's own read of `m`
answers the verdict for what `m` produced. `latest`/`isPending` restore
the dispatch they found instead of re-deriving it from their flags, so a
window opened inside the pulled pass closes back to none rather than to
the puller's (pinned: "F10 (nested window)"). `setWindows` goes away.
F10 and F11 flip from `it.fails` to `it`; the nested-window case is a new
`it` (fails on next). No other pin moved. Size: +1 B minified on the
isPending/latest scenario (+5 B brotli locally).
The brief's optional hardening of the unheld-staged arm for
STATUS_UNINITIALIZED was not added: with the pulled pass outside the
window, no reachable path served `undefined` from it in probing, so
there was no failing case to pin.
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix(signals): a verdict reader re-derives when its source settles silently (fuzzer F9)
A verdict reader holds no pending source of its own: when the source goes
pending, `propagateStatus`'s verdict arm re-derives it (CONFIG_VERDICT),
and it answers `isPending` true without inheriting the status. A flight
that then lands equal to the committed value notifies nobody — `setSignal`
skips `insertSubs` on an equal value — and the settle walk returned at
`removePendingSource` for a node without the source, so the probe read
`true` forever. Shape: `setSrc(1); setSrc(0)` re-asks an async memo for
the committed input; a probe-only `isPending(m)` reader stays true after
the re-ask lands.
A19: "a node is pending while any cause holds it and final the moment none
does". The settle walk's early return now re-derives a verdict reader it
reaches — the source settling is the reader's verdict changing, the third
transition beside `propagateStatus`'s pending and error arms. Folded into
the walk's existing early-return condition, which keeps the minifier's
single `if` (a separate branch split it and cost 25 B).
F9 flips from `it.fails` to `it`. No other pin moved. Size: +16 B
minified (core floor and every scenario carrying the settle walk).
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix(signals): a born-held effect re-run as lane work re-stages its value (fuzzer F13)
A `latest(source)` render effect whose mount is withdrawn in an action's
tick and restored in the next is born held: its creation value is staged
(`_pendingValue` 0) and its first run is the commit's (A29). The action's
final write re-runs it as the verdict lane's work, and `recompute`'s lane
arm wrote an effect's value into its private `_value` (1) — beside the
born-held staging. The lane's seam then committed the node:
`commitPendingNode` applied the stale staging (0) over the lane's run and
queued the effect's run with it, so the committed truth never showed.
A29 creation-time form ("staged into it, committed with it");
`recompute`'s own note: "an effect still carrying an uncommitted staged
value re-stages: the commit applies the latest pass, not the born-held
one". The lane arm now does the same for an effect carrying a staging; an
effect with none keeps writing its private slot for the lane's run.
F13 flips from `it.fails` to `it`. No other pin moved. Size: +13 B
minified (core floor).
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix(signals): a landing re-judges the transactions parked at its seam (fuzzer F3)
A reader mounted while a flight is up is born held (A29 ruling A);
unmounting it in the same hold stages its removal, making it a zombie
that observes another flight, and that observation blocks an unrelated
write (`src=0`) in a newer transaction (A15 #3463: a zombie is live for
every hold "until the commit that disposes it"). The seam judges
transactions newest first: the `src=0` transaction is judged blocked,
then the older hold lands (its mount control nets to committed) and its
commits dispose the zombie — but nothing judges `src=0` again. The
`schedule()` in `disposeChildren` cannot cover this: `land` has already
nulled the zombie's `_x._transaction`, and even ungated, a `schedule()`
inside `settle` is overwritten by `flush`'s own `scheduled` recompute.
`settle` now restarts its landing loop after every landing, so the
transactions it parked are judged against the world the landing
committed. The zombie is disposed, holds nothing, and `src=0` lands at
the same seam.
Deviation from the hand-off brief's triage: the brief named the
`disposeChildren` predicate (zombie's transaction nulled before the
disposing commit) as the cause and offered "schedule() for any dying
pending node" or "iterate settle to a fixpoint". The predicate is false
as triaged, but dropping it does not fix F3 (the scheduled seam is lost
inside `settle`); the fixpoint is the fix. +11 B minified (core floor).
F3 flips from `it.fails` to `it`. No other pin moved.
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix(signals): an errored pass's unreached reads still hold their flights (fuzzer F4)
A tuple render reader observes `m0`'s flight for `a=1` (the hold on
`a=1`). A later `b=1` re-runs it and the pass throws NotReady at `m1`
before reaching `m0`. `blockedBy` counts only the reader's reads of its
last pass (`s._gen === r._depGen` — O3, #3494: a reader that stopped
reading releases the flight), so the unreached `m0` link counted as
dropped, the hold on `a=1` landed, and `A=1` showed beside a tuple still
derived from `a=0` while `m0`'s flight was in the air.
A15: writes whose async work is observed by a shared reader settle as
one unit; A30: an errored pass (a throw, NotReady included) keeps its
full list. An errored pass did not stop reading — it never got there.
`blockedBy` (scheduler.ts) now counts the links past `_depsTail` as live
when the reader's pass errored (`r._x._error != null`). The unchanged-
pass tails kept for A30 (#3469) are untouched: their pass completed.
+16 B minified (core floor).
F4 flips from `it.fails` to `it`. No other pin moved.
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
* chore(size): raise nine caps for fuzz Batch A (Size-Exception, #3801)
Accepted by the maintainer (2026-10-05). Each cap is set at the CI-measured
size + 10 B, rounded up to 0.01 KB, with a dated ledger note per raise.
Fuzz Batch A (F3/F4/F9/F10-11/F13) costs +56 B minified on the core floor;
brotli layout puts nine scenarios over:
- core floor 7.33 -> 7.35 KB (floor-caps.json)
- + createStore 14.53 -> 14.56 KB
- + isPending/latest 9.47 -> 9.49 KB
- simple-app floor 9.83 -> 9.86 KB (floor-caps.json)
- hydrating 17.66 -> 17.71 KB (floor-caps.json)
- hydrating + stores 28.80 -> 28.84 KB
- CSR 12.82 -> 12.86 KB
- CSR observe tier 14.39 -> 14.46 KB
- live server components 48.47 -> 48.51 KB (floor-caps.json)
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
---------
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>1 parent 21ff8f8 commit b07fed5
13 files changed
Lines changed: 476 additions & 258 deletions
File tree
- .changeset
- packages/signals
- docs
- src/core
- tests
- scripts/size
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
261 | 268 | | |
262 | 269 | | |
263 | 270 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
620 | 620 | | |
621 | 621 | | |
622 | 622 | | |
623 | | - | |
624 | | - | |
625 | | - | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
626 | 627 | | |
627 | 628 | | |
628 | 629 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
233 | 235 | | |
234 | 236 | | |
235 | 237 | | |
| |||
314 | 316 | | |
315 | 317 | | |
316 | 318 | | |
317 | | - | |
| 319 | + | |
318 | 320 | | |
319 | 321 | | |
320 | 322 | | |
| |||
834 | 836 | | |
835 | 837 | | |
836 | 838 | | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
837 | 843 | | |
838 | 844 | | |
839 | 845 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
113 | 114 | | |
114 | 115 | | |
115 | 116 | | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | 117 | | |
121 | 118 | | |
122 | 119 | | |
| |||
228 | 225 | | |
229 | 226 | | |
230 | 227 | | |
231 | | - | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
232 | 231 | | |
233 | 232 | | |
234 | | - | |
| 233 | + | |
| 234 | + | |
235 | 235 | | |
236 | | - | |
| 236 | + | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
241 | | - | |
| 241 | + | |
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| 249 | + | |
249 | 250 | | |
250 | 251 | | |
251 | | - | |
| 252 | + | |
252 | 253 | | |
253 | 254 | | |
254 | 255 | | |
| |||
264 | 265 | | |
265 | 266 | | |
266 | 267 | | |
267 | | - | |
| 268 | + | |
268 | 269 | | |
269 | 270 | | |
270 | 271 | | |
| |||
303 | 304 | | |
304 | 305 | | |
305 | 306 | | |
306 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
307 | 315 | | |
308 | 316 | | |
309 | 317 | | |
| |||
0 commit comments