Repository navigation
Commit ad973ed
* fix(signals): a first load born under a hold holds it (column 2); drop _bornIn
A new async memo whose first pass reads a held value is held at creation,
like its sync twin (A29): its answer is the hold's, and the hold waits for
it. A fresh or re-armed boundary that catches the pass keeps it (#3540):
then the hold does not wait. This replaces #3881's _bornIn, which landed
the first answer into a live hold but never let the hold wait for it (the
direction rule's time half, withdrawn 2026-10-09).
- issue-3800-repro: a slower first load keeps the hold open; the action's
hold waits for the pages read outside a boundary.
- direction-rule-probe: the three same-tick/in-flush shapes are no longer
`it.fails` — they assert the wait.
Size (local, Rolldown): minified -22..-24 B on every scenario; core floor
7440 -> 7431 B br, hello world 9935 -> 9927 B br.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): a probe alone does not hold
A verdict read (`isPending`, `latest`) registers its reader to re-derive at
the landing — the verdict flips there — without making it a holder of the
hold. A render effect holds when its read threw, or when, beside a probe, its
plain read of the flight was served the committed value (REACTIVE_FRAME_READ,
the stale reader; #3442 / A10). #3774 routed the probe's re-run through the
stale reader, which also made it a blocker, against its own stated intent
("a probe alone is neither").
Fixes a probe-only header keeping a same-source `Loading on` re-arm's
fallback off screen (the header's probe held `data`, so the content under
the boundary was served the committed value instead of throwing).
Re-pinned (only probes read the async, so nothing holds):
- optimistic-settle-verdicts #3409: after the revert each indicator clears
with its own flight (7000 / 8000), as in the optimistic phase.
- question-scoped-pending 3.4: the list is now rendered plainly, as a <For>
would; that reader is what keeps the hold and the action's mark alive
through the refetch.
Size (local): +20 B minified on core / hello world, brotli -3 / -27 B.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): a boundary that has not shown content catches a held reader
A fresh <Loading> (never initialized) keeps a reader held by an outside
transaction on its fallback instead of joining it to the hold (#3540
re-arm shapes, 'content bound' rows now pass).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): the reader's position decides a born-held memo's catch
A memo's first pass that reads a hold is born held without joining the
tick: a render effect that reads it decides. Under a boundary that has
not shown content the boundary catches that render effect at its staging
(the pass's own status clear dropped the read-time record), so the
fallback shows now and the content at the commit. Outside one, the tick
joins the hold as before. A memo nobody renders holds nothing (#3802
re-pinned: the mount runs on committed values, never without one).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): isPending of a memo born held reads as its read
A memo born held has no committed value, so no verdict (D-23): inside an
owner, isPending of it joins the hold as a plain read of it does — held
with the change, or caught by a boundary that has not shown content —
and answers for the commit, where it is final. Unowned it is false.
latest() of it is still its pending value.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* perf(signals): one live-transaction check per seam; share the owned check
The seam resolved its transaction's liveness twice (ambient marks, then
the park decision): once now. verdictValue computes the owned-reader test
once for the tracked arm and the born-held join.
core floor 20359 -> 20330 B minified, hello world 27868 -> 27839,
isPending/latest 27508 -> 27465.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): judge an optimistic row's echo as reconcile would, not by JSON (#3898)
Redoes #3937's content check. The server's echo of a guessed store row is
a new object, so reference equality makes every echo a correction (and a
mainline until() then waits on the hold, D-31). The guess is confirmed when
reconcile would write nothing into it from the truth: wrappable pairs
descend, leaves compare as its writes do. JSON.stringify differed on key
order, undefined, Dates and cycles; this is key-order free. The check lives
in the optimistic store (GlobalQueue._echoes), so lanes without stores no
longer carry it.
isPending/latest 27465 -> 27338 B minified (9747 -> 9716 brotli); every
store family 29114 -> 29105 brotli.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): an errored reader is not re-derived at a landing (#3945)
Redoes #3954. A row binding that reads a derived-store field and
isPending is a verdict reader; the landing of the refetch's transaction
re-derived it (reruns), and that later-cycle tracked read retried the
errored store: an unrequested refetch, unbounded if it kept failing.
An errored reader's display is its error (D-39): reruns skip it. #3954's
sticky _errorMeet mark on subscribers is removed; it also stopped a
genuine re-read (the reader's own input changing) from retrying, which a
new test pins.
core floor +7 B minified, createStore -11.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* refactor(signals): refresh()'s waiter reads authoritatively (#3895)
Redoes #3895's waiter. It read the guessed node's staged truth by hand;
the waiter is now an authoritative reader (until()'s view: the truth
beneath a guess), and keeps only the part refresh adds — a guessed
node's own re-ask parks the waiter, or rejects it with its error.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* test(signals): a verdict beside a plain read shows now in either read order
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* test(signals): pin #3962 and #3957, fixed by this branch
#3962 fails on next (the #3954 mark) and passes here; #3957's rejection
reaches Errored with or without a separate isPending reader.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* fix(signals): pass a lane node's committed value as prev (#3955)
A derivation that reads `latest()` or `isPending()` of a signal an in-flight async memo is holding enters the verdict lane with `_x._lane` still `NOT_PENDING`. When that first lane pass is equal to the previous value, nothing writes the slot, so the next pass under the hold received the `NOT_PENDING` marker as `prev` and a `createSignal((prev = []) => [...prev])` threw `prev is not iterable`, halting the reactive system. The pass now falls back to the committed value when the slot is empty, as `compareValue` already does.
* fix: address review findings
The comment above the pass's previous value in `recompute` now says a lane node's lane value is used only when the slot holds one, matching the guarded expression beneath it. The #3955 test now covers `createMemo(fn)` beside `createSignal(fn)`, asserts that the landing after the equal lane passes flushes without throwing and records only arrays, and resets a halted system after each case so each case fails on its own pre-fix. The changeset describes the thrown `prev is not iterable` instead of the internal marker.
* fix(signals): review fixes for #3977
- echoes(): a self-referencing row is a correction, not a stack overflow
(next's JSON.stringify threw and fell back the same way); pinned.
- Changeset for the branch's behaviour changes.
- Dead lines removed from fresh-boundary-born-held-reader.test.ts.
- it.fails pin: an async memo created inside a fresh boundary over a held
value shows its answer before the hold commits (D-12; creation position
still decides in that shape).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* test(signals): an optimistic signal's echo is judged by its equals
Ruling 2026-10-11: signals don't reconcile, they equality-check — a
server's new array corrects unless the signal's equals says otherwise.
Pinned both ways; changeset notes the change from next's JSON compare.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* test(web): an isPending guard on a born-held memo never shows enabled early
<input disabled={isPending(data)}> over a memo born held: during the hold
the branch is held (or on its fallback under a fresh Loading), so no
enabled input over an unjudged value is ever seen; at the commit it shows
disabled=false with the committed value (D-23).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ
* test(web): drop a redundant shape comparison that failed test-types
Inside the non-direct branch `shape` is already narrowed to
"show" | "show+loading", so `shape !== "direct"` was TS2367 and failed
@solidjs/web#test-types in CI.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_017PDt8Jv6uf5xRDsrux4UwF
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
1 parent a497d4b commit ad973ed
29 files changed
Lines changed: 928 additions & 145 deletions
File tree
- .changeset
- packages
- signals
- docs
- src
- core
- store
- tests
- store
- web/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | | - | |
305 | | - | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
306 | 309 | | |
307 | 310 | | |
308 | 311 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | | - | |
35 | 33 | | |
36 | 34 | | |
37 | 35 | | |
| |||
476 | 474 | | |
477 | 475 | | |
478 | 476 | | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
| 477 | + | |
| 478 | + | |
484 | 479 | | |
485 | 480 | | |
486 | 481 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
378 | | - | |
| 377 | + | |
| 378 | + | |
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
382 | | - | |
| 382 | + | |
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
| |||
678 | 678 | | |
679 | 679 | | |
680 | 680 | | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
681 | 685 | | |
682 | 686 | | |
683 | 687 | | |
| |||
715 | 719 | | |
716 | 720 | | |
717 | 721 | | |
718 | | - | |
719 | | - | |
720 | | - | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
721 | 725 | | |
722 | 726 | | |
723 | 727 | | |
724 | 728 | | |
725 | 729 | | |
726 | | - | |
727 | | - | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
728 | 734 | | |
729 | 735 | | |
730 | 736 | | |
| |||
962 | 968 | | |
963 | 969 | | |
964 | 970 | | |
965 | | - | |
966 | 971 | | |
967 | 972 | | |
968 | 973 | | |
| |||
983 | 988 | | |
984 | 989 | | |
985 | 990 | | |
986 | | - | |
| 991 | + | |
987 | 992 | | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
988 | 998 | | |
989 | 999 | | |
990 | 1000 | | |
991 | 1001 | | |
992 | | - | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
993 | 1006 | | |
994 | 1007 | | |
995 | 1008 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | 381 | | |
394 | 382 | | |
395 | 383 | | |
396 | 384 | | |
397 | 385 | | |
398 | 386 | | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
408 | 392 | | |
409 | 393 | | |
410 | 394 | | |
| |||
0 commit comments