You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9c4e4a8
Browse filesBrowse the repository at this point in the historyBrowse files
fix(signals): don't retain the transaction a latest() read opened after it lands (#4460)
* fix(signals): don't retain the transaction a latest() read opened after it lands
`pendingVerdict` (#4453) remembered the flush's transaction a `latest`
read of an unheld flight opened in a module-level `latestJoined`, compared
only against `flushTransaction` and never cleared: after the seam it kept
the last landed transaction (its `_nodes`, `_queues`, `_reruns`) alive
until the next such read overwrote it.
The mark now lives on the transaction itself (`Transaction.latest`), so
it ends with it. Same answer for every probe: a transaction stays the
flush's from its opening to the seam, a merge keeps the flush's own, and
one merged away is no longer anyone's flush transaction, as before. The
property is not `_`-prefixed (as `folded`), so the mangler's assignment
is untouched; only bundles importing `latest`/`isPending` change, and
they shrink (isPending/latest -13 B brotli, -10 B minified).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* test(signals): the #4393/#4400 two-reader specs run on fake timers
The #4400 case writes s, waits 3 ms, and writes again while a 10 ms ask is
in flight. On CI's coverage run the real gap outlived the ask, which landed
before the second write and asked `m1:23` (seen on #4455 and #4460). The
gaps are part of each scenario, so the file now advances fake timers
instead of sleeping.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
---------
Co-authored-by: Claude <[email protected]>
The transaction a `latest()` read of an unheld refetch opens is no longer kept alive after it lands: the mark that it was opened by `latest` lives on the transaction itself instead of in a module-level reference.
0 commit comments