Skip to content

Commit 97ed6a0

Browse files
ryansolidClaude via Cursorcursoragent
committed
signals: S1 M4 — split lanes.ts into the sub-hold core and the optimistic layer
lanes-core.ts is what any lane needs: the lane record (newLane, verdictLane with its reveal record), link/blocked/reveal/landing (linkLanes, laneSeam, laneSeams, endLanes, dissolveLane, lanesBlocked), the rows of a seated pass and of a lane's node (seatRows, laneSlot, applyMarks, laneApply, laneServe), laneStage, laneWrite's derivation arm, adoptReaders. lanes.ts is the optimistic layer: pendingGuesses/optimisticWrite, applyGuesses, supersede, covered/guessFlights/laneCorrections, laneOutcome with its provenance test, take and the revert landing. The core reaches the layer's guess arms through installOptimisticHooks (guessFlights, take, covered, guessWrite, revertLanding); the scheduler's installLaneHooks loses the three hooks only the layer installs (installGuessHooks: laneOutcome, applyGuessesAt, laneCorrections). laneSlot's enter arm drops its read of `guessed`: every non-verdict lane is a guess's, so the disjunction was always true. + isPending/latest 34,354 → 32,693 min (−1,661); live page −1,662; compiled live −1,708; floors unchanged. Shadow 0 classes across signals/solid/web and the 2k × 3 generator; ASYNC_GEN_DIFF only the two known closed cases. treeshake.test.ts: the isPending-only fixtures flip to the exclusion the test anticipated. Co-authored-by: Claude via Cursor <[email protected]> Co-authored-by: Cursor <[email protected]>
1 parent a1348b1 commit 97ed6a0

7 files changed

Lines changed: 1540 additions & 1397 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@solidjs/signals": patch
3+
---
4+
5+
Reader seat S1 M4: `lanes.ts` split into the sub-hold core (`lanes-core.ts`: the lane record, link/blocked/reveal/landing, the rows of a seated pass and of a lane's node, `verdictLane` with its reveal record) and the optimistic layer (`lanes.ts`: the guesses — `optimisticWrite`, `applyGuesses`, `supersede`, the corrections, `take`/revert), the latter reached from the core through `installOptimisticHooks` and carried only by a build that imports `createOptimistic`/`createOptimisticStore`. An `isPending`/`latest`-only build no longer retains the optimistic layer (`+ isPending/latest`: −1,661 B minified). No public API change.

‎packages/signals/docs/RULES-INDEX.md‎

Lines changed: 15 additions & 15 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)