Skip to content

Commit 931aa77

Browse files
committed
fix(signals): decide the re-park sweep by deps alone, no extra core bytes (#4541)
The pass's own throw adds to the set it carried, so the has() check was always true on the notReady path and always false on the stagedErr path. retryReaches decides the first; a staged error settles all it carried. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
1 parent 137b481 commit 931aa77

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/signals/src/core/core.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -669,14 +669,14 @@ export function recompute(el: Computed<any>, create: boolean = false): void {
669669
// dependent then waits forever on a flight it has no path to. The
670670
// re-park twin of the unchanged-value recovery sweep below; dependents
671671
// with another path keep the source (retryReaches). A staged error
672-
// answered what the pass carried: the same. The pass's own throw adds
673-
// to the set it carried, so "no longer reaches" is the deps' call: a
672+
// answered what the pass carried: the same. "No longer reaches" is
673+
// the deps' call — the pass's own throw adds to the set it carried: a
674674
// first answer staged in place of its flight (uninitialized until its
675675
// commit, so its own settle walk waits) leaves the copy here while
676676
// the readers in between re-derive clean (#4541).
677677
if ((notReady || stagedErr) && outgoingPendingSources)
678678
for (const source of outgoingPendingSources)
679-
if (source !== el && (!el._x?._pendingSources?.has(source) || !retryReaches(el, source)))
679+
if (source !== el && (stagedErr || !retryReaches(el, source)))
680680
settlePendingSource(el, source);
681681
}
682682
} finally {

0 commit comments

Comments
 (0)