Skip to content

Commit 92ea317

Browse files
ryansolidClaude via Cursorcursoragent
committed
docs(room): note the #3764 exception to the shell's per-scope takeover
Co-authored-by: Claude via Cursor <[email protected]> Co-authored-by: Cursor <[email protected]>
1 parent f8437f6 commit 92ea317

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

‎examples/room/README.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,11 @@ asyncGenerator })))`, a **nested-async answer**. `live` claims the _whole
109109
the wire and killable.
110110
- **Archive** — a slow plain `GET`. Its four seconds are what the presence
111111
pill up top does _not_ wait for: the shell's live sources take over when the
112-
root pass ends, this boundary lands whenever it lands (D8).
112+
root pass ends, this boundary lands whenever it lands (D8). Exception: a
113+
shell source whose first value is still streaming when the shell flushes
114+
takes over only when the whole page has hydrated, so the Archive can delay
115+
it ([#3764](https://github.com/solidjs/solid/issues/3764); per-scope
116+
takeover for that case is [#3819](https://github.com/solidjs/solid/issues/3819)).
113117

114118
## The chaos switch
115119

‎examples/room/src/routes/live.tsx‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
// `live` re-invokes each one from its own hydration scope — the shell's
1111
// sources (presence, transcript, directory) as soon as the root pass ends,
1212
// without waiting for the slow <Loading> boundaries lower on the page (D8).
13+
// Exception (#3764): a shell source read only inside <Loading> whose first
14+
// value is still streaming when the shell flushes waits for the whole page
15+
// to hydrate, Archive included; per-scope takeover for it is #3819.
1316
import {
1417
action,
1518
createMemo,
@@ -396,8 +399,10 @@ function SummaryText(props: { room: string; attempt: number }) {
396399

397400
// ---------------------------------------------------------------------------
398401
// archive — a slow plain read in its own boundary. Its four seconds are
399-
// what the presence pill up top does NOT wait for: the shell's live sources
400-
// take over when the root pass ends, this boundary lands whenever it lands.
402+
// what the presence pill up top is not meant to wait for: the shell's live
403+
// sources take over when the root pass ends, this boundary lands whenever it
404+
// lands (except while a source's first value is still streaming; see the
405+
// note at the top and #3819).
401406
// `on={room}` makes a room switch the same story: a different room is
402407
// different content, so the boundary shows its fallback for the new room at
403408
// once instead of holding the whole navigation for the count. (A refetch of

0 commit comments

Comments
 (0)