|
1 | 1 | import { afterEach, describe, expect, it, vi } from "vitest"; |
2 | 2 | import { attribution } from "../src/attribution.js"; |
3 | 3 | import { |
| 4 | + createContext, |
4 | 5 | createEffect, |
5 | 6 | createMemo, |
6 | 7 | createRoot, |
7 | 8 | createSignal, |
8 | 9 | flush, |
9 | | - OBSERVE |
| 10 | + getContext, |
| 11 | + OBSERVE, |
| 12 | + setContext |
10 | 13 | } from "../src/index.js"; |
11 | 14 | import type { DiagnosticEvent } from "../src/core/dev.js"; |
12 | 15 |
|
@@ -79,6 +82,134 @@ describe("UNSTABLE_MEMO_OUTPUT", () => { |
79 | 82 | expect(events[0].data).toMatchObject({ shape: "array" }); |
80 | 83 | }); |
81 | 84 |
|
| 85 | + it.each(["object", "symbol", "array"])("does not evaluate %s accessors", shape => { |
| 86 | + const getter = vi.fn(() => "lazy"); |
| 87 | + const events = captureUnstable(); |
| 88 | + const [n, setN] = createSignal(0); |
| 89 | + const key = shape === "symbol" ? Symbol("children") : shape === "array" ? "0" : "children"; |
| 90 | + const dispose = createRoot(dispose => { |
| 91 | + const view = createMemo(() => { |
| 92 | + n(); |
| 93 | + return Object.defineProperty(shape === "array" ? [] : {}, key, { |
| 94 | + enumerable: true, |
| 95 | + get: getter |
| 96 | + }); |
| 97 | + }); |
| 98 | + createEffect(view, () => {}); |
| 99 | + return dispose; |
| 100 | + }); |
| 101 | + try { |
| 102 | + flush(); |
| 103 | + for (let i = 1; i <= 8; i++) { |
| 104 | + setN(i); |
| 105 | + flush(); |
| 106 | + } |
| 107 | + |
| 108 | + expect(getter).not.toHaveBeenCalled(); |
| 109 | + expect(events).toHaveLength(0); |
| 110 | + } finally { |
| 111 | + dispose(); |
| 112 | + } |
| 113 | + }); |
| 114 | + |
| 115 | + it.each([false, true])("leaves lazy context reads alone with attribution=%s", enabled => { |
| 116 | + if (enabled) captureUnstable(); |
| 117 | + const context = createContext<string>(); |
| 118 | + const [n, setN] = createSignal(0); |
| 119 | + const getter = vi.fn(() => getContext(context)); |
| 120 | + const dispose = createRoot(dispose => { |
| 121 | + setContext(context, "provided"); |
| 122 | + expect(getContext(context)).toBe("provided"); |
| 123 | + const view = createMemo(() => { |
| 124 | + n(); |
| 125 | + return { |
| 126 | + get children() { |
| 127 | + return getter(); |
| 128 | + } |
| 129 | + }; |
| 130 | + }); |
| 131 | + createEffect(view, () => {}); |
| 132 | + return dispose; |
| 133 | + }); |
| 134 | + try { |
| 135 | + flush(); |
| 136 | + setN(1); |
| 137 | + expect(() => flush()).not.toThrow(); |
| 138 | + expect(getter).not.toHaveBeenCalled(); |
| 139 | + } finally { |
| 140 | + dispose(); |
| 141 | + } |
| 142 | + }); |
| 143 | + |
| 144 | + it("does not evaluate inherited array-index accessors", () => { |
| 145 | + const getter = vi.fn(() => "inherited"); |
| 146 | + const prototype = Object.create(Array.prototype, { 0: { get: getter } }); |
| 147 | + const events = captureUnstable(); |
| 148 | + const [n, setN] = createSignal(0); |
| 149 | + const dispose = createRoot(dispose => { |
| 150 | + const view = createMemo(() => { |
| 151 | + n(); |
| 152 | + return Object.setPrototypeOf(new Array(1), prototype); |
| 153 | + }); |
| 154 | + createEffect(view, () => {}); |
| 155 | + return dispose; |
| 156 | + }); |
| 157 | + try { |
| 158 | + flush(); |
| 159 | + for (let i = 1; i <= 8; i++) { |
| 160 | + setN(i); |
| 161 | + flush(); |
| 162 | + } |
| 163 | + |
| 164 | + expect(getter).not.toHaveBeenCalled(); |
| 165 | + expect(events).toHaveLength(1); |
| 166 | + } finally { |
| 167 | + dispose(); |
| 168 | + } |
| 169 | + }); |
| 170 | + |
| 171 | + it("distinguishes array holes from own undefined values", () => { |
| 172 | + const events = captureUnstable(); |
| 173 | + const [n, setN] = createSignal(0); |
| 174 | + const dispose = createRoot(dispose => { |
| 175 | + const view = createMemo(() => (n() % 2 ? [undefined] : new Array(1))); |
| 176 | + createEffect(view, () => {}); |
| 177 | + return dispose; |
| 178 | + }); |
| 179 | + try { |
| 180 | + flush(); |
| 181 | + for (let i = 1; i <= 8; i++) { |
| 182 | + setN(i); |
| 183 | + flush(); |
| 184 | + } |
| 185 | + |
| 186 | + expect(events).toHaveLength(0); |
| 187 | + } finally { |
| 188 | + dispose(); |
| 189 | + } |
| 190 | + }); |
| 191 | + |
| 192 | + it("compares null-prototype objects", () => { |
| 193 | + const events = captureUnstable(); |
| 194 | + const [n, setN] = createSignal(0); |
| 195 | + const dispose = createRoot(dispose => { |
| 196 | + const view = createMemo(() => (n(), Object.assign(Object.create(null), { on: true }))); |
| 197 | + createEffect(view, () => {}); |
| 198 | + return dispose; |
| 199 | + }); |
| 200 | + try { |
| 201 | + flush(); |
| 202 | + for (let i = 1; i <= 8; i++) { |
| 203 | + setN(i); |
| 204 | + flush(); |
| 205 | + } |
| 206 | + |
| 207 | + expect(events).toHaveLength(1); |
| 208 | + } finally { |
| 209 | + dispose(); |
| 210 | + } |
| 211 | + }); |
| 212 | + |
82 | 213 | it("resets the streak when the output genuinely changes", () => { |
83 | 214 | const [n, setN] = createSignal(0, { name: "n" }); |
84 | 215 | // Content changes every third run — streak never reaches the threshold. |
|
0 commit comments