Skip to content

Commit 80c4bdd

Browse files
committed
test(web): drop a redundant shape comparison that failed test-types
Inside the non-direct branch `shape` is already narrowed to "show" | "show+loading", so `shape !== "direct"` was TS2367 and failed @solidjs/web#test-types in CI. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_017PDt8Jv6uf5xRDsrux4UwF
1 parent 53e9fa4 commit 80c4bdd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎packages/web/test/ispending-guard-born-held.spec.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ for (const shape of ["show", "show+loading", "direct"] as const)
3131
{shape === "direct" ? (
3232
<Show when={direct()}>{(() => <Form />) as any}</Show>
3333
) : (
34-
<Show when={open() && shape !== "direct"}>
34+
<Show when={open()}>
3535
{
3636
(() =>
3737
shape === "show+loading" ? (

0 commit comments

Comments
 (0)