You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7ce3c98
Browse filesBrowse the repository at this point in the historyBrowse files
fix(solid): an Errored fallback's own failure goes to the next boundary up; its wait is budgeted (#4316, #4317)
#4316: when a <Loading> fails after the shell and its <Errored> renders the
fallback as the outcome (renderOutcome), a fallback hole that rejected
while the server waited for it was swallowed. The retry ran with no owner,
so the hole's error never met a handler and the outcome came back empty.
Parked in a pending outer <Loading>, the inner fragment then settled as a
blank child, and the client hydrated the blank and halted. A fallback that
threw synchronously reached the parent handler instead, but in its
no-consumer mode: an outer <Errored> serialized its error record and
rendered a fallback nobody sent.
Now a failure of the fallback, sync or async, goes to the next boundary
up. The fallback owner's handler holds it while the outcome renders, and
the retry runs under that owner. The parent is first asked for the outcome
at the same position, so an outer <Errored> whose whole content is that
position draws its fallback there and serializes its error with it.
Otherwise the failure is routed as a content failure, so a pending outer
<Loading> fails its fragment. An outer <Errored> reached that way while
it is not being pulled lets it pass and does not render.
#4317: the wait now shares the <Loading> resume loop's convergence budget
(MAX_RESUME_PASSES, internal; hydration.ts uses it in place of the 10000
literal). Past the budget it answers what is available, which is no
finished fallback. It also races each wait against the fallback owner's
teardown, so an aborted render stops waiting at once.
Tests: sync-throw twins for the parked and unparked shapes, with and
without an outer <Errored>. The server harness holds the async variant's
markup to the twin's. The hydrate spec holds its client outcome, loaded
and streamed, to the twin's, and a caught variant must claim the outer
fallback. Server specs cover the budget (a fresh pending source every
pass) and the abort.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
Server: when an `<Errored>` renders its fallback for a `<Loading>` that failed after the shell, and a hole in that fallback rejects while the server waits for it, the rejection now goes to the next boundary up, as it does when a fallback throws synchronously. Inside a pending outer `<Loading>`, that outer fragment fails; under an outer `<Errored>` whose whole content is that position, the outer fallback is drawn there and the client adopts it. Before, the region streamed blank and the hydrating client halted (#4316). A synchronous throw in that fallback no longer writes an error record for an outer `<Errored>` without sending its fallback.
6
+
7
+
The server's wait for that fallback now stops after the same pass budget as the `<Loading>` resume loop and then streams what it has. It also stops as soon as the render is torn down, for example when the request is aborted (#4317).
0 commit comments