Repository navigation
Commit 756b1b3
signals: omit()'s copy path re-homes accessors with the source as receiver
A prop's getter is defined only for a read through its own object. The
plain-object merge() path already binds a copied getter to its source;
omit()'s no-Proxy path forwarded the descriptor as-is, so a getter that
keeps state on the instance (the compiler's server props, #3511) would
throw on the first read of the copy. Both copy paths now follow the
same rule, the rule is written down on merge(), and isStatic()'s note
about server/client parity says what is actually equal: the descriptors.
Co-authored-by: Claude via Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>1 parent ead76f4 commit 756b1b3
3 files changed
Lines changed: 76 additions & 5 deletions
File tree
- .changeset
- packages/signals
- src/store
- tests/store
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
252 | | - | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
253 | 255 | | |
254 | 256 | | |
255 | 257 | | |
| |||
943 | 945 | | |
944 | 946 | | |
945 | 947 | | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
946 | 956 | | |
947 | 957 | | |
948 | 958 | | |
| |||
1143 | 1153 | | |
1144 | 1154 | | |
1145 | 1155 | | |
1146 | | - | |
1147 | | - | |
1148 | | - | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
1149 | 1171 | | |
1150 | 1172 | | |
1151 | 1173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
151 | 195 | | |
152 | 196 | | |
153 | 197 | | |
| |||
0 commit comments