Skip to content

Commit 7384573

Browse files
ryansolidclaude
andauthored
chore: a seat-shadow build can't be published; the carve brief points at its stop (#4448)
Follow-ups from #4438's review. - verify-release-artifacts.mjs (run by release.mjs before anything is published) fails when a fixed package's tarball carries `__SEAT_SHADOW__`, the mark a SIGNALS_TEST_DEFINE=true build leaves in @solidjs/signals' dist/dev-shared.js. A shadow build is a test build (rollup.config.js: "never for measuring or publishing"). - reader-seat-brief.md §4 says the swap stopped and points at reader-seat-rebuild.md §8, which supersedes it. Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2 Co-authored-by: Claude <[email protected]>
1 parent b249ad9 commit 7384573

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

‎documentation/plans/reader-seat-brief.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@ Baseline must be zero on E4/E5/E9 after §2 lands.
9090

9191
## 4. The carve: rebuild beside, then swap
9292

93+
> **Stopped (2026-10-29).** S1 failed its gate (the 50k differential and
94+
> size) and the swap is not going ahead. S0 + M1 landed as a CI spec
95+
> (#4438). `reader-seat-rebuild.md` §8 is the record and supersedes this
96+
> section; what follows is the plan as it stood.
97+
9398
The model and the table stand; the plan is no longer the nine-step fold.
9499
The design is `reader-seat-rebuild.md`: the seat and the slot table are
95100
built _beside_ the existing deciders as `core/seat.ts` (+ the display-ahead

‎scripts/verify-release-artifacts.mjs‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,18 @@ for (const [name, { directory, pkg }] of directories) {
6565

6666
const files = new Set(report.files.map(file => file.path));
6767
const missing = [...collectEntryFiles(pkg)].filter(entry => !files.has(entry));
68-
if (missing.length > 0) {
68+
// A dist built with SIGNALS_TEST_DEFINE=true carries the reader-seat
69+
// shadow (`__TEST__` on): a test build, never one to publish.
70+
const shadowed = [...files].filter(
71+
file =>
72+
/\.[cm]?js$/.test(file) &&
73+
fs.readFileSync(`${directory}/${file}`, "utf8").includes("__SEAT_SHADOW__")
74+
);
75+
if (shadowed.length > 0) {
76+
failures.push(
77+
`${name}: built with SIGNALS_TEST_DEFINE=true (the seat shadow is in ${shadowed.join(", ")}); rebuild without it`
78+
);
79+
} else if (missing.length > 0) {
6980
failures.push(
7081
`${name}: the published tarball would be missing manifest entry points: ${missing.join(", ")}`
7182
);

0 commit comments

Comments
 (0)