Repository navigation
Commit 667dcff
* fix(signals): unread key written beside a held sibling publishes at flush (#4146)
A setter outside the holding transaction writing a store key that a held
container's staging left unchanged wrote it into the held staging, so plain
reads waited for the hold's landing, unless a live reader's leaf gave the
key its own staging. The key now gets its leaf before the write (R1, #3706),
kept while the container is held.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): golf the #4146 held-key leaf (+80 B min on store scenarios)
Inline the leaf creation into the set trap and fold the held-host check
into the existing release conditions; drop conditions the remaining ones
already cover.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* size: raise store caps for the #4146 held-key leaf
CI measured +80 B minified on the two store scenarios. Caps at CI
brotli + 10 B, recorded minified = CI's minified.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* docs(signals): regenerate RULES-INDEX for the golfed #4146 leaf
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): share slotKept, give every held-container write its leaf (#4146)
Golf from review of #4159 (-32 B min on the store scenarios):
- G1: one `slotKept(node)` predicate for the slot-release handler and the
deferred-release drain (no behaviour change).
- G2: drop `key in pb` and `!heldKeyChanged` from the set trap. `bornStaged`
already holds a leaf only for a key the held staging changed, so a changed
key still joins the hold (A34), and an added key (or an index appended to
a held array) now gets the same unheld leaf a reader's would. Its value
shows at the flush whether or not anything reads it (R1: node existence
is unobservable). Before, an unread added key waited for the hold while a
read one published.
New test pins that reader-invariance; it fails without G2. The changeset no
longer says array writes join the hold: an index the hold left unchanged
publishes at the flush, and appended indexes/added keys publish their value
while length/key membership waits for the landing.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* size: re-set #4146 caps from CI after the golf
+48 B minified on the store scenarios (was +80). The compiled hydrating
app crossed its brotli cap by 18 B, so it gets a ledger entry too.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
---------
Co-authored-by: Claude <[email protected]>
1 parent 8c75f82 commit 667dcff
5 files changed
Lines changed: 306 additions & 18 deletions
File tree
- .changeset
- packages/signals
- docs
- src/store
- tests
- scripts/size
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
345 | 353 | | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
| 354 | + | |
350 | 355 | | |
351 | 356 | | |
352 | 357 | | |
| |||
898 | 903 | | |
899 | 904 | | |
900 | 905 | | |
901 | | - | |
902 | | - | |
903 | | - | |
904 | | - | |
905 | | - | |
| 906 | + | |
906 | 907 | | |
907 | 908 | | |
908 | 909 | | |
| |||
2179 | 2180 | | |
2180 | 2181 | | |
2181 | 2182 | | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
| 2194 | + | |
2182 | 2195 | | |
2183 | 2196 | | |
2184 | 2197 | | |
| |||
0 commit comments