Skip to content

Commit 623ec33

Browse files
committed
docs(signals): why catchStatus's cleared path needs no staged-error guard (#4364)
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
1 parent d1b1c0b commit 623ec33

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/signals/src/boundaries.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,11 @@ function catchStatus(
238238
// waited on settling re-derives the output now, in the same heap (a
239239
// held reader's landing has joined its transaction, so the content
240240
// lands with its run, not a round after). Others still waiting: nothing
241-
// on screen changes, the fallback stays as it is.
241+
// on screen changes, the fallback stays as it is. `node` here is an
242+
// effect reporting its own status. An error boundary records an effect
243+
// only while it is errored, and a staged error keeps STATUS_ERROR on a
244+
// node that had it (`stageError`), so `prune`'s CONFIG_STAGED_ERROR case
245+
// cannot reach this path (#4364).
242246
if (collecting.size !== 0)
243247
for (let b: Boundary | null | undefined = boundaryOf(node); b; b = b._parent)
244248
if (

0 commit comments

Comments
 (0)