Skip to content

Commit 542ff6f

Browse files
ryansolidclaude
andauthored
fix(solid,web): a failed Errored waits for its fallback's async holes before streaming (#4308)
* fix(solid,web): draw an Errored fallback for a Loading's async failure, and adopt it (#4287) Outside a server component, a <Loading> whose async read failed during a streamed render settled its fragment blank, and the hydrating client rendered the failed boundary from scratch: it asked again and showed the loading fallback. Server: the failing <Loading> now asks the enclosing <Errored> for its outcome outside server components too, passing its own id. The Errored answers only when that Loading is all of its content (its resolved markup is the Loading's placeholder): its fallback is drawn into the fragment, or inlined pre-flush, and the error is serialized at the Errored id. Deeper in the content it answers nothing, as before. A rejected fragment's template is marked `e`, and `$dfr` records the nodes it swaps in for it. Client: inside a hydrated Errored's no-claim content run, a <Loading> runs its content with its data adopted instead of waiting on its fragment, so the Errored holds the client's own error and tracks the content's inputs (#4273). A boundary that claimed its fallback and then renders a rejected fragment fresh clears the nodes the swap put in first, so nothing of the server's outcome is left beside the client's render. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2 * fix(solid): serialize an Errored's error only when its fallback markup is sent When a streamed <Loading> fails after the shell and asks the enclosing <Errored> for its outcome, the fallback may hold an async hole that has not resolved yet. renderOutcome then returns no markup (the fragment settles as a plain rejection), but handleError had already serialized the error at the Errored id. A client hydrating after the failure read that record, claimed a fallback that was never sent, and went blank with a hydration key miss. The outcome path now defers the record and writes it only once the fallback resolved to finished markup. Without it the client renders the failure itself, as on `next`. Server-only; no client bytes. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1 * fix(solid,web): stream a parked Errored fallback once its async hole resolves (#4306) An <Errored> whose fallback reads async data, around a <Loading> that fails after the shell inside an outer <Loading> still pending, lost its region: the outcome render met the fallback's pending hole, answered no markup, and the parked fragment spliced a blank into the outer one while its `_fr` resolved. The client claimed against the blank and showed nothing there, with hydration warnings. renderOutcome now answers a still-resolving fallback with a function that waits out its holes and returns the finished markup, serializing the error only then. The <Loading> calls it only while its fragment is parked in an enclosing pending one (the registry's new `parked()` query on the settle function), where nothing of the failure shows yet: the outer fragment carries the fallback, or, if the outer settles first, the inner fragment streams it when it lands. A failure in a region already shown settles at once, as before. Server-only; no client bytes. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2 * fix(solid,web): a failed Errored always waits for its fallback's async holes (#4306) Per RULES-DERIVED D-18 (a swap to a fallback waits for the fallback to be ready), the wait for an Errored fallback's async holes no longer depends on the fragment being parked. A <Loading> that fails after the shell under an <Errored> whose fallback is still resolving keeps its placeholder until the finished fallback is ready, then streams it with the error record, in the parked case (carried by the outer fragment while that is pending) and the unparked one alike. The registry's `parked()` query is dropped. #4303's async-fallback scenario now expects the server's finished fallback and its record: a client hydrating after the failure arrived claims it and asks nothing again. Server-only; no client bytes. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2 --------- Co-authored-by: Claude <[email protected]>
1 parent e509ad1 commit 542ff6f

9 files changed

Lines changed: 301 additions & 47 deletions
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"solid-js": patch
3+
"@solidjs/web": patch
4+
---
5+
6+
An `<Errored>` whose fallback reads async data, around a `<Loading>` that fails after the shell, now streams its fallback once that data is ready, and a client hydrating after it arrived claims it. Before, the failure landed while the fallback's read was still pending, so the server had no markup for it. On its own, the boundary swapped to a blank and the client rendered the failure itself, asking for the failed read again. Inside an outer `<Loading>` still pending, the outer fragment arrived with the Errored region blank, and the client hydrated against the blank with warnings and showed nothing there. Now the failure waits for the fallback, as a swap to a fallback waits for the fallback to be ready: the loading placeholder stays until the finished fallback replaces it (carried by the outer fragment when that is still pending), and the error is serialized with it (#4306).

‎packages/solid/src/server/hydration.ts‎

Lines changed: 42 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ function ssrLoadingBoundary(
179179
const timed = IS_DEV || observed;
180180
const discoveredAt = timed ? performance.now() : 0;
181181
let recorded = false;
182-
let streamedOnError = false;
182+
let streamedOnError: boolean | Promise<boolean> = false;
183183
let pendingRecord: (() => void) | undefined;
184184
const record = (outcome: BoundaryEvent["outcome"], streamed: boolean, error?: unknown) => {
185185
if (recorded) return;
@@ -378,10 +378,18 @@ function ssrLoadingBoundary(
378378
// Hydration ids inside the rendered fallback are the component's own
379379
// hydration-free scope's; its head and asset registrations drop with the
380380
// error, as the error path drops them today.
381-
function errorOutcome(err: any): { value?: string; escaped?: { frame?: string } } | undefined {
381+
// An `<Errored>` fallback still resolving answers with a function (see
382+
// `renderOutcome`): the failure waits for it, as a client swap to a
383+
// fallback waits for the fallback to be ready (RULES-DERIVED D-18) — the
384+
// placeholder stays until the finished fallback replaces it, or, parked
385+
// in an enclosing pending fragment, that fragment carries it (#4306).
386+
type Outcome = { value?: string; escaped?: { frame?: string } } | undefined;
387+
function errorOutcome(err: any, wait?: boolean): Outcome | Promise<Outcome> {
382388
const scoped = inServerComponentScope(o as any);
383389
const rendered = parentHandler ? parentHandler(err, scoped || id) : undefined;
384390
if (typeof rendered === "string") return { value: rendered };
391+
if (typeof rendered === "function" && wait)
392+
return rendered().then(value => (value === undefined ? undefined : { value }));
385393
if (scoped) return { value: plainFallback(), escaped: { frame: ctx.frameId } };
386394
}
387395
// Settle the fragment with the failure. The server error hook hears of it
@@ -393,19 +401,24 @@ function ssrLoadingBoundary(
393401
// Whether the last failure's outcome was rendered by a server <Errored>
394402
// (its own finding names it; the "client re-renders" one would be wrong).
395403
let outcomeRendered = false;
396-
function failFragment(err: any, report: boolean): boolean {
397-
const outcome = errorOutcome(err);
398-
outcomeRendered = !!outcome && outcome.value !== undefined && !outcome.escaped;
399-
if (report && !outcomeRendered) {
400-
reportServerError(
401-
err,
402-
{ kind: "render", handling: "client", boundary: id },
403-
o,
404-
ctx.errorPolicy,
405-
ctx._errorScope
406-
);
407-
}
408-
return done!(outcome && outcome.value, err, outcome && outcome.escaped);
404+
// With `wait`, answers a promise where the outcome is still resolving (see
405+
// errorOutcome): the fragment settles when it lands.
406+
function failFragment(err: any, report: boolean, wait?: boolean): boolean | Promise<boolean> {
407+
const settle = (outcome: Outcome) => {
408+
outcomeRendered = !!outcome && outcome.value !== undefined && !outcome.escaped;
409+
if (report && !outcomeRendered) {
410+
reportServerError(
411+
err,
412+
{ kind: "render", handling: "client", boundary: id },
413+
o,
414+
ctx.errorPolicy,
415+
ctx._errorScope
416+
);
417+
}
418+
return done!(outcome && outcome.value, err, outcome && outcome.escaped);
419+
};
420+
const outcome = errorOutcome(err, wait);
421+
return outcome instanceof Promise ? outcome.then(settle) : settle(outcome);
409422
}
410423

411424
function runLoadingPhase<T>(render: () => T): T {
@@ -431,8 +444,9 @@ function ssrLoadingBoundary(
431444
// hydration before the fragment channel can engage. (Inside a
432445
// server component the nearest server `<Errored>` IS asked — for
433446
// its rendered outcome, not to route; see errorOutcome.)
434-
streamedOnError = failFragment(err, true);
435-
if (!outcomeRendered) reportRouted(err, "client");
447+
streamedOnError = failFragment(err, true, true);
448+
if (!(streamedOnError instanceof Promise) && !outcomeRendered)
449+
reportRouted(err, "client");
436450
throw err;
437451
}
438452
// Synchronous discovery (no fragment yet): the enclosing Errored's
@@ -460,10 +474,16 @@ function ssrLoadingBoundary(
460474
// flushed — for that pre-shell case, and for a parent handler that itself
461475
// throws, route through the renderer's containment channel instead: the
462476
// request fails (onError + wind-down), the process survives.
463-
function finalizeError(err: any) {
477+
function finalizeError(err: any): void | Promise<void> {
464478
if (handledRenderError === err) {
465479
handledRenderError = undefined;
466-
record("error", streamedOnError, err);
480+
const settling = streamedOnError;
481+
if (settling instanceof Promise)
482+
return settling.then(streamed => {
483+
if (!outcomeRendered) reportRouted(err, "client");
484+
record("error", streamed, err);
485+
});
486+
record("error", settling, err);
467487
return;
468488
}
469489
if (done) {
@@ -737,7 +757,9 @@ function ssrLoadingBoundary(
737757
const streamed = done!(ret && Array.isArray(ret.t) ? ret.t[0] : ((ret && ret.t) as any));
738758
record("settled", streamed);
739759
} catch (err) {
740-
finalizeError(err);
760+
// A failure whose outcome is still resolving settles when it lands.
761+
const settling = finalizeError(err);
762+
if (settling) await settling;
741763
} finally {
742764
// The slot settles either way: on error, `done(undefined, err)` wrote
743765
// the fragment template and rejects `key_fr`, so the client error path

‎packages/solid/src/server/signals.ts‎

Lines changed: 33 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3708,7 +3708,9 @@ export function repeat<T>(
37083708
* asking `<Loading>`'s id, and an `<Errored>` answers only when that
37093709
* Loading is all of its content (#4287).
37103710
*/
3711-
export type BoundaryErrorHandler = (err: any, outcome?: true | string) => string | undefined | void;
3711+
export type BoundaryErrorHandler = (err: any, outcome?: true | string) => BoundaryOutcome;
3712+
/** A rendered outcome; a function where it is still resolving (see renderOutcome). */
3713+
export type BoundaryOutcome = string | (() => Promise<string | undefined>) | undefined | void;
37123714

37133715
const ErrorContext: Context<BoundaryErrorHandler | null> = {
37143716
id: Symbol("ErrorContext"),
@@ -3761,7 +3763,7 @@ export function runWithBoundaryErrorContext<T>(
37613763
err: any,
37623764
parentHandler: BoundaryErrorHandler | null,
37633765
outcome?: true | string
3764-
) => string | undefined | void,
3766+
) => BoundaryOutcome,
37653767
context?: NonNullable<typeof sharedConfig.context>,
37663768
boundaryId?: string
37673769
): T {
@@ -4275,7 +4277,12 @@ export function createErrorBoundary<T, U>(
42754277
// all of its content: the fallback then lands where the client twin draws
42764278
// it, and the error serialized here lets it adopt that markup. Deeper in
42774279
// the content it answers nothing — the client renders the failure fresh.
4278-
const renderOutcome = (err: any, outcome: true | string): string | undefined => {
4280+
// Asked by a `<Loading>` (outside a server component), a fallback still
4281+
// resolving answers with a function instead: called, it waits out the
4282+
// fallback's holes and answers with the finished markup (or `undefined`,
4283+
// a client hole or a failure in it), serializing the error only then
4284+
// (#4306).
4285+
const renderOutcome = (err: any, outcome: true | string): BoundaryOutcome => {
42794286
let t = shown && shown.t;
42804287
if (Array.isArray(t)) t = t[0];
42814288
if (
@@ -4289,19 +4296,32 @@ export function createErrorBoundary<T, U>(
42894296
return undefined;
42904297
// Rendered from a resume loop, where the render context the compiled
42914298
// template reads has long moved past this boundary's: restore it.
4292-
const prevCtx = sharedConfig.context;
4293-
sharedConfig.context = ctx;
4294-
try {
4295-
const resolved: any = ctx.resolve(ctx.escape(handleError(err, true)));
4296-
if (!resolved || (resolved.h && resolved.h.length)) return undefined;
4299+
const inCtx = (run: () => any) => {
4300+
const prevCtx = sharedConfig.context;
4301+
sharedConfig.context = ctx;
4302+
try {
4303+
return run();
4304+
} catch {
4305+
} finally {
4306+
sharedConfig.context = prevCtx;
4307+
}
4308+
};
4309+
const finish = (resolved: any) => {
4310+
if (!resolved || (resolved.h && resolved.h.length)) return;
42974311
if (deferredWire) (serializeError(deferredWire), (deferredWire = undefined));
42984312
const t = resolved.t;
42994313
return Array.isArray(t) ? t[0] : t;
4300-
} catch {
4301-
return undefined;
4302-
} finally {
4303-
sharedConfig.context = prevCtx;
4304-
}
4314+
};
4315+
let resolved: any = inCtx(() => ctx.resolve(ctx.escape(handleError(err, true))));
4316+
if (outcome === true || !resolved || !resolved.h || !resolved.h.length) return finish(resolved);
4317+
return async () => {
4318+
while (resolved && resolved.p && resolved.p.length) {
4319+
if (resolved.p.some((p: any) => p.$clientHole)) return;
4320+
await Promise.all(resolved.p).catch(() => {});
4321+
resolved = inCtx(() => ctx.ssr(resolved.t, ...resolved.h));
4322+
}
4323+
return finish(resolved);
4324+
};
43054325
};
43064326
// `$lhSkip`: boundary machinery owns this position (see ssrLoadingBoundary)
43074327
// — a live binding over the boundary's output would re-run resolve(),
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"name": "errored-loading-parked-rejection-async-fallback-4306",
3+
"shell": "<div _hk=3><!--$--><template id=\"pl-4\"></template><i _hk=40>outer loading</i><!--pl-4--><!--/--><span>tail</span></div><script>(self.$R=self.$R||{})[\"\"]=[];_$HY.r[\"0\"]=$R[0]=($R[1]=($R[2]=() => {\n\tconst resolver = {\n\t\tp: 0,\n\t\ts: 0,\n\t\tf: 0\n\t};\n\tresolver.p = new Promise((resolve, reject) => {\n\t\tresolver.s = resolve;\n\t\tresolver.f = reject;\n\t});\n\treturn resolver;\n})()).p;_$HY.r[\"1\"]=$R[3]=($R[4]=$R[2]()).p;_$HY.r[\"2\"]=$R[5]=($R[6]=$R[2]()).p;_$HY.r[\"400200_fr\"]=$R[7]=($R[8]=$R[2]()).p;_$HY.r[\"4_fr\"]=$R[9]=($R[10]=$R[2]()).p;</script>",
4+
"rest": "<script>($R[12]=(resolver, data) => {\n\tresolver.f(data);\n\tresolver.p.s = 2;\n\tresolver.p.v = data;\n})($R[4],$R[11]=new Error(\"no user 7\"));</script><script>($R[13]=(resolver, data) => {\n\tresolver.s(data);\n\tresolver.p.s = 1;\n\tresolver.p.v = data;\n})($R[6],\"HINT\");_$HY.r[\"4002\"]=$R[11];</script><script>$R[13]($R[8],!0);</script><template id=\"4\"><b _hk=4000>outer</b><p _hk=40030>failed: <!--$-->no user 7<!--/--> <!--$-->HINT<!--/--></p></template><script>$R[13]($R[1],\"outer\");$df(\"4\");function $df(e){return _$HY.f?_$HY.f(e):$dfr(e)}function $dfr(e,n,o,t){if(!(n=document.getElementById(e)))return 0;if(!(o=document.getElementById(\"pl-\"+e)))return(_$HY.dq=_$HY.dq||{})[e]=1,0;for(;o&&(8!==o.nodeType||o.nodeValue!==\"pl-\"+e);)t=o.nextSibling,o.remove(),o=t;t=o.parentNode,(_$HY.v=_$HY.v||{})[e]=n.hasAttribute(\"e\")?[...n.content.childNodes]:1,o.replaceWith(n.content),n.remove(),_$HY.fe(e,t),_$HY.hp&&_$HY.hp[e]&&($dh(_$HY.hp[e]),delete _$HY.hp[e]),$dfd();return 1}function $dfl(e,o,n){if(!(o=document.getElementById(\"pl-\"+e)))return(_$HY.dlq=_$HY.dlq||{})[e]=1,0;if(o._$fl)return 1;for(n=o.nextSibling;n;){if(8===n.nodeType&&n.nodeValue===\"pl-\"+e){o.parentNode&&o.parentNode.insertBefore(o.content.cloneNode(!0),n),o._$fl=1,$dfd();return 1}n=n.nextSibling}return 0}function $dflj(e,i){for(i=0;i<e.length;i++)$dfl(e[i])}function $dfd(e,i){if(e=_$HY.dq){_$HY.dq=0;for(i in e)$df(i)}if(e=_$HY.dlq){_$HY.dlq=0;for(i in e)$dfl(i)}}function $dfs(e,c,d){(_$HY.sc=_$HY.sc||{})[e]=c,d&&((_$HY.sd=_$HY.sd||{})[e]=1)}function $dfg(e,g,i,k){if(!(g=_$HY.sg&&_$HY.sg[e]))return;for(i=0;i<g.length;i++)if(_$HY.sc&&_$HY.sc[g[i]]>0)return;for(i=0;i<g.length;i++)k=g[i],delete _$HY.sg[k],$df(k)}function $dfc(e){if(--_$HY.sc[e]<=0){delete _$HY.sc[e],_$HY.sg&&_$HY.sg[e]?$dfg(e):!(_$HY.sd&&_$HY.sd[e])&&$df(e);_$HY.sd&&delete _$HY.sd[e]}}function $dfj(e,i,n){for(i=0;i<e.length;i++)if(_$HY.sc&&_$HY.sc[e[i]]>0){for(n=0;n<e.length;n++)(_$HY.sg=_$HY.sg||{})[e[n]]=e;return}for(i=0;i<e.length;i++)$df(e[i])}function $dfe(e,t,k){(t=e.target)&&t.getAttribute&&!t._$dc&&(k=t.getAttribute(\"data-dfc\"))&&(t._$dc=1,$dfc(k))}document.addEventListener(\"load\",$dfe,!0);document.addEventListener(\"error\",$dfe,!0);</script><script>$R[13]($R[10],!0);</script>"
5+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"name": "errored-loading-parked-rejection-late-async-fallback-4306",
3+
"shell": "<div _hk=3><!--$--><template id=\"pl-4\"></template><i _hk=40>outer loading</i><!--pl-4--><!--/--><span>tail</span></div><script>(self.$R=self.$R||{})[\"\"]=[];_$HY.r[\"0\"]=$R[0]=($R[1]=($R[2]=() => {\n\tconst resolver = {\n\t\tp: 0,\n\t\ts: 0,\n\t\tf: 0\n\t};\n\tresolver.p = new Promise((resolve, reject) => {\n\t\tresolver.s = resolve;\n\t\tresolver.f = reject;\n\t});\n\treturn resolver;\n})()).p;_$HY.r[\"1\"]=$R[3]=($R[4]=$R[2]()).p;_$HY.r[\"2\"]=$R[5]=($R[6]=$R[2]()).p;_$HY.r[\"400200_fr\"]=$R[7]=($R[8]=$R[2]()).p;_$HY.r[\"4_fr\"]=$R[9]=($R[10]=$R[2]()).p;</script>",
4+
"rest": "<script>($R[12]=(resolver, data) => {\n\tresolver.f(data);\n\tresolver.p.s = 2;\n\tresolver.p.v = data;\n})($R[4],$R[11]=new Error(\"no user 7\"));</script><template id=\"4\"><b _hk=4000>outer</b><template id=\"pl-400200\"></template><i _hk=4002000>loading</i><!--pl-400200--></template><script>($R[13]=(resolver, data) => {\n\tresolver.s(data);\n\tresolver.p.s = 1;\n\tresolver.p.v = data;\n})($R[1],\"outer\");$df(\"4\");function $df(e){return _$HY.f?_$HY.f(e):$dfr(e)}function $dfr(e,n,o,t){if(!(n=document.getElementById(e)))return 0;if(!(o=document.getElementById(\"pl-\"+e)))return(_$HY.dq=_$HY.dq||{})[e]=1,0;for(;o&&(8!==o.nodeType||o.nodeValue!==\"pl-\"+e);)t=o.nextSibling,o.remove(),o=t;t=o.parentNode,(_$HY.v=_$HY.v||{})[e]=n.hasAttribute(\"e\")?[...n.content.childNodes]:1,o.replaceWith(n.content),n.remove(),_$HY.fe(e,t),_$HY.hp&&_$HY.hp[e]&&($dh(_$HY.hp[e]),delete _$HY.hp[e]),$dfd();return 1}function $dfl(e,o,n){if(!(o=document.getElementById(\"pl-\"+e)))return(_$HY.dlq=_$HY.dlq||{})[e]=1,0;if(o._$fl)return 1;for(n=o.nextSibling;n;){if(8===n.nodeType&&n.nodeValue===\"pl-\"+e){o.parentNode&&o.parentNode.insertBefore(o.content.cloneNode(!0),n),o._$fl=1,$dfd();return 1}n=n.nextSibling}return 0}function $dflj(e,i){for(i=0;i<e.length;i++)$dfl(e[i])}function $dfd(e,i){if(e=_$HY.dq){_$HY.dq=0;for(i in e)$df(i)}if(e=_$HY.dlq){_$HY.dlq=0;for(i in e)$dfl(i)}}function $dfs(e,c,d){(_$HY.sc=_$HY.sc||{})[e]=c,d&&((_$HY.sd=_$HY.sd||{})[e]=1)}function $dfg(e,g,i,k){if(!(g=_$HY.sg&&_$HY.sg[e]))return;for(i=0;i<g.length;i++)if(_$HY.sc&&_$HY.sc[g[i]]>0)return;for(i=0;i<g.length;i++)k=g[i],delete _$HY.sg[k],$df(k)}function $dfc(e){if(--_$HY.sc[e]<=0){delete _$HY.sc[e],_$HY.sg&&_$HY.sg[e]?$dfg(e):!(_$HY.sd&&_$HY.sd[e])&&$df(e);_$HY.sd&&delete _$HY.sd[e]}}function $dfj(e,i,n){for(i=0;i<e.length;i++)if(_$HY.sc&&_$HY.sc[e[i]]>0){for(n=0;n<e.length;n++)(_$HY.sg=_$HY.sg||{})[e[n]]=e;return}for(i=0;i<e.length;i++)$df(e[i])}function $dfe(e,t,k){(t=e.target)&&t.getAttribute&&!t._$dc&&(k=t.getAttribute(\"data-dfc\"))&&(t._$dc=1,$dfc(k))}document.addEventListener(\"load\",$dfe,!0);document.addEventListener(\"error\",$dfe,!0);</script><script>$R[13]($R[10],!0);</script><script>$R[13]($R[6],\"HINT\");_$HY.r[\"4002\"]=$R[11];</script><template id=\"400200\" e><p _hk=40030>failed: <!--$-->no user 7<!--/--> <!--$-->HINT<!--/--></p></template><script>$df(\"400200\");</script><script>$R[12]($R[8],$R[11]);</script>"
5+
}

0 commit comments

Comments
 (0)