Repository navigation
Commit 404d06a
* fix(signals): a re-pass equal to a staged first value is not a change (#4540)
A node whose first value is staged in the running flush stays
STATUS_UNINITIALIZED until the commit, and recompute counted every
re-pass of it as a change. A non-keyed Show whose condition first
answers in a flush (an async memo or projection landing) re-ran its
value memo on each re-pass and remounted its child; a child writing the
source from its render effect's synchronous first run looped.
The uninitialized test now applies only when nothing is staged: with a
staged first value, the equality gate compares against it (INV-11), as
for any staged node.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): fold the #4540 staged check into the existing staged local
The first cut read `_pendingValue` again at the top of recompute and cost
+8 B minified on every core row. The equality gate already reads it for
compareValue and the effect gate reads it a third time; one `unstaged`
local now serves all three, and the uninitialized term checks it at the
gate. Core rows are back to +0 B minified, and the gate does one fewer
property load per pass.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
* fix(signals): order the #4540 gate term for size
`unstaged && wasUninitialized && !isEffect`, with wasUninitialized kept as
the raw status bit, minifies 4 B smaller than the boolean-coerced form and
keeps the brotli rows under their caps. The `!!` moves to the observe-only
devChanged assignment, which needs a boolean. Same logic.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2
---------
Co-authored-by: Claude <[email protected]>
1 parent 718ec9c commit 404d06a
3 files changed
Lines changed: 86 additions & 10 deletions
File tree
- .changeset
- packages
- signals/src/core
- web/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
520 | 520 | | |
521 | 521 | | |
522 | 522 | | |
523 | | - | |
| 523 | + | |
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
| |||
790 | 790 | | |
791 | 791 | | |
792 | 792 | | |
793 | | - | |
794 | | - | |
795 | | - | |
796 | | - | |
797 | | - | |
798 | | - | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
799 | 799 | | |
800 | 800 | | |
801 | 801 | | |
802 | 802 | | |
803 | 803 | | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
804 | 807 | | |
805 | | - | |
| 808 | + | |
806 | 809 | | |
807 | 810 | | |
808 | 811 | | |
809 | 812 | | |
810 | 813 | | |
811 | 814 | | |
812 | 815 | | |
813 | | - | |
| 816 | + | |
814 | 817 | | |
815 | 818 | | |
816 | 819 | | |
| |||
830 | 833 | | |
831 | 834 | | |
832 | 835 | | |
833 | | - | |
| 836 | + | |
834 | 837 | | |
835 | 838 | | |
836 | 839 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
0 commit comments